New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config.image.defaultToolbar #60

Closed
Reinmar opened this Issue Feb 24, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Reinmar
Copy link
Member

Reinmar commented Feb 24, 2017

As explained in ckeditor/ckeditor5-ui#155 (comment).

For now, we're going to require that you specify the config. We'll create a system to pre-configure this by features in the future (see ckeditor/ckeditor5#409).

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Feb 28, 2017

#64 (comment)

Let's not forget that the in all our samples and everywhere the toolbar should be configured as styles | alt.

Reinmar added a commit to CKEditor5/ckeditor5.github.io that referenced this issue Apr 20, 2017

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Apr 20, 2017

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Apr 20, 2017

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Apr 20, 2017

I changed the order of buttons in the classic build (ckeditor/ckeditor5-build-classic@131cbe7) and on https://ckeditor5.github.io (CKEditor5/ckeditor5.github.io@ff4ffcf). What remains here is getting rid of defaultToolbar setting.

@oleq oleq added this to the iteration 10 milestone Apr 20, 2017

@oleq oleq self-assigned this Apr 24, 2017

oleq added a commit that referenced this issue Apr 24, 2017

@Reinmar Reinmar closed this in #103 Apr 24, 2017

Reinmar added a commit that referenced this issue Apr 24, 2017

Merge pull request #103 from ckeditor/t/60
Other: Removed automatically filled `config.image.defaultToolbar`. Now, when initializing editor one must always define `config.image.toolbar`. Closes #60.

BREAKING CHANGE: The `config.image.defaultToolbar` is no longer available. All editor instances must configure `config.image.toolbar` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment