Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text transformation happens on backspace #3153

Closed
scofalik opened this issue Jul 8, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-typing#213
Closed

Text transformation happens on backspace #3153

scofalik opened this issue Jul 8, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-typing#213
Assignees
@jodator
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@scofalik
Copy link
Contributor

scofalik commented Jul 8, 2019

Since text transformation does not check whether actually typing has happened, text transformation triggers on backspace.

Jul-08-2019 15-22-11
@jodator jodator self-assigned this Jul 19, 2019
scofalik referenced this issue in ckeditor/ckeditor5-typing Jul 24, 2019
@scofalik
Merge pull request #213 from ckeditor/t/208
0e26850 
Feature: Introduced `Input#isInput()`. Closes #214. Fixed the `TextTransformation` feature so it willl trigger only for typing changes. Closes #208.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

T/208: TextTransformation should only consider typing changes ckeditor/ckeditor5-typing
3 participants
@jodator @scofalik @mlewand