From 5e6a2573160dcf021d489e0cea72316595e36350 Mon Sep 17 00:00:00 2001 From: Illia Sheremetov Date: Tue, 13 Jun 2023 14:40:51 +0200 Subject: [PATCH 1/4] Fix (table): define overflow-wrap with breaking-word in css --- packages/ckeditor5-table/theme/table.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/ckeditor5-table/theme/table.css b/packages/ckeditor5-table/theme/table.css index 2389da4eff7..10d1752cd79 100644 --- a/packages/ckeditor5-table/theme/table.css +++ b/packages/ckeditor5-table/theme/table.css @@ -52,6 +52,10 @@ when content is available outside the editor. See https://github.com/ckeditor/ck text-align: left; } +.ck.ck-content .table td { + overflow-wrap: break-word; +} + .ck-editor__editable .ck-table-bogus-paragraph { /* * Use display:inline-block to force Chrome/Safari to limit text mutations to this element. From bfe5f2fdecb1afd4c40616a6d8e4d546fc5589ce Mon Sep 17 00:00:00 2001 From: Illia Sheremetov Date: Tue, 13 Jun 2023 14:45:08 +0200 Subject: [PATCH 2/4] Fix (table): delete .ck selector --- packages/ckeditor5-table/theme/table.css | 4 ---- packages/ckeditor5-table/theme/tablecolumnresize.css | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/ckeditor5-table/theme/table.css b/packages/ckeditor5-table/theme/table.css index 10d1752cd79..2389da4eff7 100644 --- a/packages/ckeditor5-table/theme/table.css +++ b/packages/ckeditor5-table/theme/table.css @@ -52,10 +52,6 @@ when content is available outside the editor. See https://github.com/ckeditor/ck text-align: left; } -.ck.ck-content .table td { - overflow-wrap: break-word; -} - .ck-editor__editable .ck-table-bogus-paragraph { /* * Use display:inline-block to force Chrome/Safari to limit text mutations to this element. diff --git a/packages/ckeditor5-table/theme/tablecolumnresize.css b/packages/ckeditor5-table/theme/tablecolumnresize.css index a0e5c1c0153..d0f6b98a743 100644 --- a/packages/ckeditor5-table/theme/tablecolumnresize.css +++ b/packages/ckeditor5-table/theme/tablecolumnresize.css @@ -23,6 +23,7 @@ .ck-content .table td, .ck-content .table th { position: relative; + overflow-wrap: break-word; } .ck.ck-editor__editable .table .ck-table-column-resizer { From 481d41e00222b2bdfc6642128cdfe435fee003fb Mon Sep 17 00:00:00 2001 From: Illia Sheremetov Date: Tue, 13 Jun 2023 16:56:29 +0200 Subject: [PATCH 3/4] Doc (table): add docs for overflow-wrap property --- packages/ckeditor5-table/theme/tablecolumnresize.css | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/ckeditor5-table/theme/tablecolumnresize.css b/packages/ckeditor5-table/theme/tablecolumnresize.css index d0f6b98a743..f153f4bb5ef 100644 --- a/packages/ckeditor5-table/theme/tablecolumnresize.css +++ b/packages/ckeditor5-table/theme/tablecolumnresize.css @@ -22,8 +22,10 @@ .ck-content .table td, .ck-content .table th { - position: relative; + /* To prevent text overflowing beyond its cell when columns are resized by resize handler + (https://github.com/ckeditor/ckeditor5/pull/14379). */ overflow-wrap: break-word; + position: relative; } .ck.ck-editor__editable .table .ck-table-column-resizer { From c4c80442d0f63e6cb1c8f3b98840a26e7216060d Mon Sep 17 00:00:00 2001 From: Illia Sheremetov Date: Wed, 14 Jun 2023 12:08:39 +0200 Subject: [PATCH 4/4] Docs (table): update link. Link of issue -> link of comment --- packages/ckeditor5-table/theme/tablecolumnresize.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ckeditor5-table/theme/tablecolumnresize.css b/packages/ckeditor5-table/theme/tablecolumnresize.css index f153f4bb5ef..05d09c5099d 100644 --- a/packages/ckeditor5-table/theme/tablecolumnresize.css +++ b/packages/ckeditor5-table/theme/tablecolumnresize.css @@ -23,7 +23,7 @@ .ck-content .table td, .ck-content .table th { /* To prevent text overflowing beyond its cell when columns are resized by resize handler - (https://github.com/ckeditor/ckeditor5/pull/14379). */ + (https://github.com/ckeditor/ckeditor5/pull/14379#issuecomment-1589460978). */ overflow-wrap: break-word; position: relative; }