Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The contrast between selected and unselected find and replace result is too low #10242

Closed
oleq opened this issue Jul 28, 2021 · 4 comments · Fixed by #10397
Closed

The contrast between selected and unselected find and replace result is too low #10242

oleq opened this issue Jul 28, 2021 · 4 comments · Fixed by #10397
Assignees
@arkflpc
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 46 (v29...

Comments

@oleq
Copy link
Member

oleq commented Jul 28, 2021

📝 Provide detailed reproduction steps (if any)

First result selected

Second result selected

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. domain:accessibility This issue reports an accessibility problem. squad:core Issue to be handled by the Core team. package:find-and-replace labels Jul 28, 2021
@oleq oleq added this to the iteration 46 milestone Jul 28, 2021
@Reinmar Reinmar modified the milestones: iteration 46, nice-to-have Aug 4, 2021
@Reinmar Reinmar removed this from the iteration 46 milestone Aug 16, 2021
@Reinmar Reinmar mentioned this issue Aug 16, 2021
Merged
@Reinmar Reinmar added this to the iteration 46 milestone Aug 16, 2021
@arkflpc
Copy link
Contributor

arkflpc commented Aug 18, 2021

Some other products use different colors for selected and unselected search results:

Google Docs
Google Chrome native search
Firefox native search
TinyMCE

@Reinmar
Copy link
Member

Reinmar commented Aug 18, 2021

Standards.... standards everywhere :D

@Reinmar
Copy link
Member

Reinmar commented Aug 18, 2021

My 2 cents: Google Chrome's native colors are closest to what we have now, so this would be the smallest change and thus easiest to accept. I'd go this way. Fortunately, this is something we can revisit easily too, so there's little point to process it more thoroughly.

@Reinmar
Copy link
Member

Reinmar commented Aug 18, 2021

One thing that I checked: Chrome's colors are standardized across at least Linux (where you checked them, I suppose) and macOS. This is a good news :D

@arkflpc arkflpc mentioned this issue Aug 23, 2021
Merged
oleq added a commit that referenced this issue Aug 23, 2021
@oleq
Merge pull request #10397 from ckeditor/ck/10242
f5a2c57 
Other (find-and-replace): Increased the contrast between selected and unselected find and replace results. Closes #10242.
@Reinmar Reinmar mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 46 (v29.2.0)
Development

Successfully merging a pull request may close this issue.

Increase the contrast between selected and unselected find and replac… ckeditor/ckeditor5
3 participants
@Reinmar @oleq @arkflpc