New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds should not define a shortened config version #572

Closed
Reinmar opened this Issue Sep 30, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@Reinmar
Copy link
Member

Reinmar commented Sep 30, 2017

I tried to create an editor (using the classic build):

return ClassicEditor
	.create( document.querySelector( '#snippet-classic-editor' ), {
		toolbar: {
			viewportTopOffset: 60
		}
	} )

Which didn't work well because no toolbar items were rendered. This is because the build specifies config.toolbar = [ 'item1', 'item2' ... ] so setting that to the object format overrides the value completely.

Instead, if the build will configure config.toolbar.items = [ ... ] everything will work fine.

@Reinmar Reinmar added this to the iteration 12 milestone Sep 30, 2017

@Reinmar Reinmar self-assigned this Sep 30, 2017

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Sep 30, 2017

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Sep 30, 2017

Of course, if we configure toolbar items through config.toolbar.items one can still override them easily through config.toolbar (using the simplified format).

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Sep 30, 2017

Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Sep 30, 2017

Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment