Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign errors found in CI build to proper categories #8344

Closed
psmyrek opened this issue Oct 26, 2020 · 1 comment
Closed

Assign errors found in CI build to proper categories #8344

psmyrek opened this issue Oct 26, 2020 · 1 comment
Assignees
Labels
intro Good first ticket. squad:devops Issue to be handled by the Devops team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@psmyrek
Copy link
Contributor

psmyrek commented Oct 26, 2020

馃摑 Provide a description of the improvement

Currently the scripts/continuous-integration-script.js assigns all errors found during CI build as unit tests errors, because the add method is always called on the unitTests set. It should be changed to something like failedChecks[ checkName ].add( packageName );


If you'd like to see this improvement implemented, add a 馃憤 reaction to this post.

@psmyrek psmyrek added type:improvement This issue reports a possible enhancement of an existing feature. intro Good first ticket. squad:devops Issue to be handled by the Devops team. labels Oct 26, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Dec 14, 2020
@pomek
Copy link
Member

pomek commented Feb 5, 2021

Fixed in the past,

failedChecks[ checkName ].add( packageName );

@pomek pomek closed this as completed Feb 5, 2021
@pomek pomek self-assigned this Feb 5, 2021
@pomek pomek modified the milestones: nice-to-have, iteration 40 Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. squad:devops Issue to be handled by the Devops team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants