Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(advanced-setup): add section for Webpack Encore #1956

Open
wants to merge 2 commits into
base: master
from

Conversation

@Kocal
Copy link

commented Aug 12, 2019

Suggested merge commit message (convention)

Docs: Added docs for building from source in Webpack Encore


Hi, today I've had some issues while trying to make Webpack Encore able to build CKEditor5, but I've finally make it works and I think it will be helpful for other people.

Thanks

@Reinmar Reinmar requested a review from oleq Aug 14, 2019

@oleq

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

I'm glad you managed to get it to work. And thanks for the PR!

I'm not sure this is the right place for this kind of docs, though. Feels more like Builds/Guides/Frameworks but we need to figure out where to keep it because this section is devoted mainly to official CKEditor 5 components for 3rd-party frameworks.

cc @Reinmar

@Kocal

This comment has been minimized.

Copy link
Author

commented Aug 19, 2019

Hum, I don't really know.
A separate page for Webpack Encore would be a copy/paste from Webpack page, but with a different webpack.config.js 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.