Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple editor instances inserted for review multiline comment #55

Closed
f1ames opened this issue Feb 3, 2020 · 3 comments · Fixed by #67
Closed

Multiple editor instances inserted for review multiline comment #55

f1ames opened this issue Feb 3, 2020 · 3 comments · Fixed by #67
Assignees
Labels
bug Something isn't working

Comments

@f1ames
Copy link

f1ames commented Feb 3, 2020

See below:

@fredck
Copy link
Contributor

fredck commented Feb 4, 2020

The integration with inline code comments is quite delicate. GitHub uses pjax in the Pull Request pages and this makes things much harder. The extension disables pjax in a few pages but maybe some are still missing. As disabling pjax is something to be done on the links that open the code review page, the following information is very important. So here it goes my question:

tl;dr - what is the exact path you do to reach the commit page where you see this error?

@fredck fredck added the question Further information is requested label Feb 4, 2020
@f1ames
Copy link
Author

f1ames commented Feb 6, 2020

This happens kind of randomly 😕 Encountered it today, checked few repos and it was happening. The path is just:

  1. Go to any repo.
  2. Switch to Pull requests tab.
  3. Open any PR.
  4. Switch to File changes tab.
  5. Create multiline comment.

Long story short, I have then detached one Chrome tab to record a gif and it stopped happening 😆 


Took a look once again and I start to suspect that it is somehow related to having multiple tabs opened:

It's not really visible on the gif above but after creating first multiline comment I'm opening the second tab with the same repo (different PR) and creating another multiline comment.

@fredck fredck added bug Something isn't working and removed question Further information is requested labels Feb 7, 2020
@fredck
Copy link
Contributor

fredck commented Feb 7, 2020

Good news! Was able to reproduce it following your previous comment.

Bad news! Was able to reproduce it following your previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants