Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

We need visual feedback when a game is won or lost #14

Closed
ckolderup opened this Issue Feb 20, 2012 · 8 comments

Comments

Projects
None yet
4 participants
Owner

ckolderup commented Feb 20, 2012

It should end the game with a win message or something.

@irondavy irondavy was assigned Feb 21, 2012

Collaborator

hoverbird commented Feb 21, 2012

I can easily tack on a message like "the game is won" but I was wondering if there is a more definitive way to message this. Any ideas, @irondavy?

Collaborator

irondavy commented Mar 5, 2012

Here's what I'm thinking:

I pushed the CSS for this: #game p.end.

It would also be worth considering sliding the verb bar off the screen at this point as well.

Collaborator

irondavy commented Mar 5, 2012

I don't expect the links to do anything in V1, certainly.

Owner

ckolderup commented Mar 5, 2012

The links are pretty easy. "/games/by/{username}" and then just look up the proper syntax for twitter/facebook share URLs to "/game/{slug}". I'm sure we can get those in there in some fashion.

Collaborator

irondavy commented Mar 11, 2012

Clearing myself as assignee since the design is done, and CSS is checked in.

Collaborator

ardubs commented Mar 11, 2012

this looks lovely. nice!

Collaborator

hoverbird commented Mar 11, 2012

Awesome!

Collaborator

hoverbird commented Jun 20, 2013

This works now. It should show the message attached to the win event, and it displays the author's name as a link as shown above.

@hoverbird hoverbird closed this Jun 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment