This repository has been archived by the owner. It is now read-only.

Upgrade base to bootstrap 2.0? #9

Open
jaddison opened this Issue Feb 1, 2012 · 39 comments

Comments

Projects
None yet
@jaddison

jaddison commented Feb 1, 2012

I'm not sure if this is a feasible request or not, but bootstrap 2.0 has been released (twitter's version). is it worth it to re-base this repo on the updated twitter-bootstrap?

I'm going to guess not...

@andycjw

This comment has been minimized.

Show comment
Hide comment
@andycjw

andycjw Feb 2, 2012

i'm currently using this as swapable style, and since upgrading to newer bootstrap 2.0, i had to remove fbootstrap

andycjw commented Feb 2, 2012

i'm currently using this as swapable style, and since upgrading to newer bootstrap 2.0, i had to remove fbootstrap

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 2, 2012

Would love to see an upgrade to bootstrap 2.0...

Would love to see an upgrade to bootstrap 2.0...

@ckrack

This comment has been minimized.

Show comment
Hide comment
@ckrack

ckrack Feb 3, 2012

Owner

I'll definitely look into a port.
I'll keep you updated on the progress right here.

Owner

ckrack commented Feb 3, 2012

I'll definitely look into a port.
I'll keep you updated on the progress right here.

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 3, 2012

awesome. any idea on timing?

awesome. any idea on timing?

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 4, 2012

for what it is worth, I'd be happy to help. let me know what you think.

for what it is worth, I'd be happy to help. let me know what you think.

@rochacbruno

This comment has been minimized.

Show comment
Hide comment
@rochacbruno

rochacbruno Feb 7, 2012

+1, I can help on porting to 2.0

+1, I can help on porting to 2.0

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 8, 2012

Hey Andy, What do you mean a swappable style?

Hey Andy, What do you mean a swappable style?

@ckrack

This comment has been minimized.

Show comment
Hide comment
@ckrack

ckrack Feb 8, 2012

Owner

Hey guys.
Very busy days, i just had an exam and had to celebrate the excellent grade a bit.

Some help would be greatly appreciated, of course.
I'll have to get started with the basics and push these first though, so we have a base to work on.
I'll give you a heads up, as soon as i have gotten around doing that.

Owner

ckrack commented Feb 8, 2012

Hey guys.
Very busy days, i just had an exam and had to celebrate the excellent grade a bit.

Some help would be greatly appreciated, of course.
I'll have to get started with the basics and push these first though, so we have a base to work on.
I'll give you a heads up, as soon as i have gotten around doing that.

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 8, 2012

congrats! keep us posted...

congrats! keep us posted...

@andycjw

This comment has been minimized.

Show comment
Hide comment
@andycjw

andycjw Feb 9, 2012

@plainspace I should have said css style switcher, something like this, http://www.centerkey.com/style/switcher/

andycjw commented Feb 9, 2012

@plainspace I should have said css style switcher, something like this, http://www.centerkey.com/style/switcher/

@ckrack

This comment has been minimized.

Show comment
Hide comment
@ckrack

ckrack Feb 10, 2012

Owner

This just in: http://www.allfacebook.com/facebook-timeline-pages-2012-01
Facebook might announce timeline for fanpages on 29th february.

I wanted to bring this up anyways, so we might discuss it here:
As you can see, timeline pages look different than the normal facebook UI.
They feature a grey background with white boxes, use rounded corners and have a more modern appeal.
I'm guessing that facebook will revamp the remaining parts of the site, as soon as both profiles and fanpages are converted to that new look.

So, instead of just allowing the usage of the new elements within bootstrap 2.0, we might go for a proper 2.0 release of fbootstrapp which is built for the "new" look.
What do you guys think?

Owner

ckrack commented Feb 10, 2012

This just in: http://www.allfacebook.com/facebook-timeline-pages-2012-01
Facebook might announce timeline for fanpages on 29th february.

I wanted to bring this up anyways, so we might discuss it here:
As you can see, timeline pages look different than the normal facebook UI.
They feature a grey background with white boxes, use rounded corners and have a more modern appeal.
I'm guessing that facebook will revamp the remaining parts of the site, as soon as both profiles and fanpages are converted to that new look.

So, instead of just allowing the usage of the new elements within bootstrap 2.0, we might go for a proper 2.0 release of fbootstrapp which is built for the "new" look.
What do you guys think?

@cmer

This comment has been minimized.

Show comment
Hide comment
@cmer

cmer Feb 10, 2012

+1

cmer commented Feb 10, 2012

+1

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 10, 2012

i think it makes sense to adopt new fb design elements. seems like using current profile timeline elements should do the trick. do you have an idea on timing?

i think it makes sense to adopt new fb design elements. seems like using current profile timeline elements should do the trick. do you have an idea on timing?

@jessor

This comment has been minimized.

Show comment
Hide comment
@jessor

jessor Feb 14, 2012

Sounds good, but what does it mean exactly? Which elements would be particularly interesting for fbootstrap? Unfortunately, noone really knows how the timeline pages will look, so should we wait for it?

jessor commented Feb 14, 2012

Sounds good, but what does it mean exactly? Which elements would be particularly interesting for fbootstrap? Unfortunately, noone really knows how the timeline pages will look, so should we wait for it?

@ckrack

This comment has been minimized.

Show comment
Hide comment
@ckrack

ckrack Feb 14, 2012

Owner

Yes, that is exactly what i was thinking about.
We might need new dimensions aswell and other things could change, too.

In the meantime you can use the current version.

Owner

ckrack commented Feb 14, 2012

Yes, that is exactly what i was thinking about.
We might need new dimensions aswell and other things could change, too.

In the meantime you can use the current version.

@jessor

This comment has been minimized.

Show comment
Hide comment
@jessor

jessor Feb 14, 2012

Yep, fair enough, imho.

jessor commented Feb 14, 2012

Yep, fair enough, imho.

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 14, 2012

Waiting for Facebook? Do you think they are going to change the canvas size? The fixed app canvas is currently 760 and the timeline canvas is 849. For some reason I don't think they are going to change the app canvas. It would mess up so many app developers. You can use the whole thing if you want anyway. What do you think of a making fbootstrapp 2.0 with the same element styles but with the ability to use a fixed or a fluid grid? Then people can customize the width but still retain the fb for bootstrap styles.

I'd like to get working on a port to 2.0. Can you give me any tips about how you set it up with the current version? Are the styles all in one file or spread out over the less and css files?

Waiting for Facebook? Do you think they are going to change the canvas size? The fixed app canvas is currently 760 and the timeline canvas is 849. For some reason I don't think they are going to change the app canvas. It would mess up so many app developers. You can use the whole thing if you want anyway. What do you think of a making fbootstrapp 2.0 with the same element styles but with the ability to use a fixed or a fluid grid? Then people can customize the width but still retain the fb for bootstrap styles.

I'd like to get working on a port to 2.0. Can you give me any tips about how you set it up with the current version? Are the styles all in one file or spread out over the less and css files?

@artlung

This comment has been minimized.

Show comment
Hide comment
@artlung

artlung Feb 22, 2012

Sounds like what we have is a "wontfix" - basically fbootstrap will remain tied to Twitter Bootstrap 1, and future versions of FBootstrap will wait until the next (relentless) styling change Facebook rolls out. Correct?

artlung commented Feb 22, 2012

Sounds like what we have is a "wontfix" - basically fbootstrap will remain tied to Twitter Bootstrap 1, and future versions of FBootstrap will wait until the next (relentless) styling change Facebook rolls out. Correct?

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Feb 22, 2012

i wish it wasn't true! waiting for Facebook? ug.

i wish it wasn't true! waiting for Facebook? ug.

@tmchow

This comment has been minimized.

Show comment
Hide comment
@tmchow

tmchow Feb 26, 2012

+1 for Bootstrap 2.0 support! I wouldn't wait for FB's new styles.

tmchow commented Feb 26, 2012

+1 for Bootstrap 2.0 support! I wouldn't wait for FB's new styles.

@yguedidi

This comment has been minimized.

Show comment
Hide comment
@yguedidi

yguedidi Feb 27, 2012

@tmchow +1

@jessor

This comment has been minimized.

Show comment
Hide comment
@jessor

jessor Feb 29, 2012

The timeline for pages is here: https://www.facebook.com/about/pages

Most important change for us is probably the new app width (810px).

jessor commented Feb 29, 2012

The timeline for pages is here: https://www.facebook.com/about/pages

Most important change for us is probably the new app width (810px).

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Mar 2, 2012

interesting. is the app width changing too? I don't see that yet on the dev tools. seems like page width and app width might not be the same?

interesting. is the app width changing too? I don't see that yet on the dev tools. seems like page width and app width might not be the same?

@rkischuk

This comment has been minimized.

Show comment
Hide comment
@rkischuk

rkischuk Mar 3, 2012

App width is 810px for page apps. I've added a new layout option and sent a pull request.

rkischuk commented Mar 3, 2012

App width is 810px for page apps. I've added a new layout option and sent a pull request.

@jessor

This comment has been minimized.

Show comment
Hide comment
@rkischuk

This comment has been minimized.

Show comment
Hide comment
@rkischuk

rkischuk Mar 3, 2012

Noticed this last night when my app looked ugly. Gotta love Facebook, their bugs, and their bug fix process. Maybe expect a real fix on Tuesday.

rkischuk commented Mar 3, 2012

Noticed this last night when my app looked ugly. Gotta love Facebook, their bugs, and their bug fix process. Maybe expect a real fix on Tuesday.

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Mar 7, 2012

So the app canvas is going to be the same width as the new page width?

So the app canvas is going to be the same width as the new page width?

@jaddison

This comment has been minimized.

Show comment
Hide comment
@jaddison

jaddison Mar 22, 2012

I'm not trying to tread on toes here, just providing my point of view: fbootstrapp is a project created based on Twitter's Bootstrap project - obvious, I know. ;)

My point is that this project should primarily track its foundational features and functionality - that is, any changes in Twitter's Bootstrap should be reflected first and foremost. Anything else should be considered scope creep. I'm not saying that FB Timeline support shouldn't be added, but not at the expense of compatibility with the original Bootstrap or release timing.

If possible, adding extra functionality like Timeline or new FB page widths should be an add-on. If approached this way, then perhaps upgrading when Bootstrap 3.0 is released might be easier.

Edit: Perhaps a plugin or module based-approach might be feasible? LESS is quite flexible, so this should be realistic. I use a great 3rd party app available here https://github.com/earle/django-bootstrap to make Django forms work seamlessly with Twitter Bootstrap; for a while (pre-Bootstrap 2.0), this worked well with this Facebook version of Bootstrap. But then things fell apart with the 2.0 release. Anyhow, just some feedback on the project's approach - I don't think anyone expected such significant changes in Bootstrap, so it was hard to predict.

I'm not trying to tread on toes here, just providing my point of view: fbootstrapp is a project created based on Twitter's Bootstrap project - obvious, I know. ;)

My point is that this project should primarily track its foundational features and functionality - that is, any changes in Twitter's Bootstrap should be reflected first and foremost. Anything else should be considered scope creep. I'm not saying that FB Timeline support shouldn't be added, but not at the expense of compatibility with the original Bootstrap or release timing.

If possible, adding extra functionality like Timeline or new FB page widths should be an add-on. If approached this way, then perhaps upgrading when Bootstrap 3.0 is released might be easier.

Edit: Perhaps a plugin or module based-approach might be feasible? LESS is quite flexible, so this should be realistic. I use a great 3rd party app available here https://github.com/earle/django-bootstrap to make Django forms work seamlessly with Twitter Bootstrap; for a while (pre-Bootstrap 2.0), this worked well with this Facebook version of Bootstrap. But then things fell apart with the 2.0 release. Anyhow, just some feedback on the project's approach - I don't think anyone expected such significant changes in Bootstrap, so it was hard to predict.

@plainspace

This comment has been minimized.

Show comment
Hide comment
@plainspace

plainspace Mar 22, 2012

+1

+1

@yguedidi

This comment has been minimized.

Show comment
Hide comment
@yguedidi

yguedidi Apr 1, 2012

+1

yguedidi commented Apr 1, 2012

+1

@mcintyre321

This comment has been minimized.

Show comment
Hide comment
@mcintyre321

mcintyre321 Apr 18, 2012

+1

+1

@devdave

This comment has been minimized.

Show comment
Hide comment
@devdave

devdave Apr 19, 2012

+1

devdave commented Apr 19, 2012

+1

@nunziofiore

This comment has been minimized.

Show comment
Hide comment
@nunziofiore

nunziofiore May 1, 2012

+1

+1

@jbrooksuk

This comment has been minimized.

Show comment
Hide comment
@jbrooksuk

jbrooksuk Jun 6, 2012

Any news on this?

Any news on this?

@recidive

This comment has been minimized.

Show comment
Hide comment
@recidive

recidive Jul 5, 2012

Hey, any news on this? Is there anything to test?

recidive commented Jul 5, 2012

Hey, any news on this? Is there anything to test?

@dexterbt1

This comment has been minimized.

Show comment
Hide comment
@dexterbt1

dexterbt1 Aug 9, 2012

+1

+1

@BenoitNorrin

This comment has been minimized.

Show comment
Hide comment
@BenoitNorrin

BenoitNorrin Sep 23, 2012

+1

+1

@rizidoro

This comment has been minimized.

Show comment
Hide comment
@rizidoro

rizidoro Sep 24, 2012

+1

+1

@ilsken

This comment has been minimized.

Show comment
Hide comment
@ilsken

ilsken Apr 2, 2013

+1

ilsken commented Apr 2, 2013

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.