Skip to content

Upgrade base to bootstrap 2.0? #9

Open
jaddison opened this Issue Feb 1, 2012 · 39 comments
@jaddison
jaddison commented Feb 1, 2012

I'm not sure if this is a feasible request or not, but bootstrap 2.0 has been released (twitter's version). is it worth it to re-base this repo on the updated twitter-bootstrap?

I'm going to guess not...

@andycjw
andycjw commented Feb 2, 2012

i'm currently using this as swapable style, and since upgrading to newer bootstrap 2.0, i had to remove fbootstrap

@plainspace

Would love to see an upgrade to bootstrap 2.0...

@ckrack
Owner
ckrack commented Feb 3, 2012

I'll definitely look into a port.
I'll keep you updated on the progress right here.

@plainspace

awesome. any idea on timing?

@plainspace

for what it is worth, I'd be happy to help. let me know what you think.

@rochacbruno

+1, I can help on porting to 2.0

@plainspace

Hey Andy, What do you mean a swappable style?

@ckrack
Owner
ckrack commented Feb 8, 2012

Hey guys.
Very busy days, i just had an exam and had to celebrate the excellent grade a bit.

Some help would be greatly appreciated, of course.
I'll have to get started with the basics and push these first though, so we have a base to work on.
I'll give you a heads up, as soon as i have gotten around doing that.

@plainspace

congrats! keep us posted...

@andycjw
andycjw commented Feb 9, 2012

@plainspace I should have said css style switcher, something like this, http://www.centerkey.com/style/switcher/

@ckrack
Owner
ckrack commented Feb 10, 2012

This just in: http://www.allfacebook.com/facebook-timeline-pages-2012-01
Facebook might announce timeline for fanpages on 29th february.

I wanted to bring this up anyways, so we might discuss it here:
As you can see, timeline pages look different than the normal facebook UI.
They feature a grey background with white boxes, use rounded corners and have a more modern appeal.
I'm guessing that facebook will revamp the remaining parts of the site, as soon as both profiles and fanpages are converted to that new look.

So, instead of just allowing the usage of the new elements within bootstrap 2.0, we might go for a proper 2.0 release of fbootstrapp which is built for the "new" look.
What do you guys think?

@cmer
cmer commented Feb 10, 2012

+1

@plainspace

i think it makes sense to adopt new fb design elements. seems like using current profile timeline elements should do the trick. do you have an idea on timing?

@jessor
jessor commented Feb 14, 2012

Sounds good, but what does it mean exactly? Which elements would be particularly interesting for fbootstrap? Unfortunately, noone really knows how the timeline pages will look, so should we wait for it?

@ckrack
Owner
ckrack commented Feb 14, 2012

Yes, that is exactly what i was thinking about.
We might need new dimensions aswell and other things could change, too.

In the meantime you can use the current version.

@jessor
jessor commented Feb 14, 2012

Yep, fair enough, imho.

@plainspace

Waiting for Facebook? Do you think they are going to change the canvas size? The fixed app canvas is currently 760 and the timeline canvas is 849. For some reason I don't think they are going to change the app canvas. It would mess up so many app developers. You can use the whole thing if you want anyway. What do you think of a making fbootstrapp 2.0 with the same element styles but with the ability to use a fixed or a fluid grid? Then people can customize the width but still retain the fb for bootstrap styles.

I'd like to get working on a port to 2.0. Can you give me any tips about how you set it up with the current version? Are the styles all in one file or spread out over the less and css files?

@artlung
artlung commented Feb 22, 2012

Sounds like what we have is a "wontfix" - basically fbootstrap will remain tied to Twitter Bootstrap 1, and future versions of FBootstrap will wait until the next (relentless) styling change Facebook rolls out. Correct?

@plainspace

i wish it wasn't true! waiting for Facebook? ug.

@tmchow
tmchow commented Feb 26, 2012

+1 for Bootstrap 2.0 support! I wouldn't wait for FB's new styles.

@jessor
jessor commented Feb 29, 2012

The timeline for pages is here: https://www.facebook.com/about/pages

Most important change for us is probably the new app width (810px).

@plainspace

interesting. is the app width changing too? I don't see that yet on the dev tools. seems like page width and app width might not be the same?

@rkischuk
rkischuk commented Mar 3, 2012

App width is 810px for page apps. I've added a new layout option and sent a pull request.

@rkischuk
rkischuk commented Mar 3, 2012

Noticed this last night when my app looked ugly. Gotta love Facebook, their bugs, and their bug fix process. Maybe expect a real fix on Tuesday.

@plainspace

So the app canvas is going to be the same width as the new page width?

@jaddison

I'm not trying to tread on toes here, just providing my point of view: fbootstrapp is a project created based on Twitter's Bootstrap project - obvious, I know. ;)

My point is that this project should primarily track its foundational features and functionality - that is, any changes in Twitter's Bootstrap should be reflected first and foremost. Anything else should be considered scope creep. I'm not saying that FB Timeline support shouldn't be added, but not at the expense of compatibility with the original Bootstrap or release timing.

If possible, adding extra functionality like Timeline or new FB page widths should be an add-on. If approached this way, then perhaps upgrading when Bootstrap 3.0 is released might be easier.

Edit: Perhaps a plugin or module based-approach might be feasible? LESS is quite flexible, so this should be realistic. I use a great 3rd party app available here https://github.com/earle/django-bootstrap to make Django forms work seamlessly with Twitter Bootstrap; for a while (pre-Bootstrap 2.0), this worked well with this Facebook version of Bootstrap. But then things fell apart with the 2.0 release. Anyhow, just some feedback on the project's approach - I don't think anyone expected such significant changes in Bootstrap, so it was hard to predict.

@plainspace

+1

@yguedidi
yguedidi commented Apr 1, 2012

+1

@mcintyre321

+1

@devdave
devdave commented Apr 19, 2012

+1

@nunziofiore

+1

@jbrooksuk

Any news on this?

@recidive
recidive commented Jul 5, 2012

Hey, any news on this? Is there anything to test?

@dexterbt1

+1

@BenoitNorrin

+1

@rizidoro

+1

@ilsken
ilsken commented Apr 2, 2013

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.