Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set conv2d to use scratch memory on gpu #692

Merged
merged 2 commits into from Jul 13, 2017
Merged

Set conv2d to use scratch memory on gpu #692

merged 2 commits into from Jul 13, 2017

Conversation

@neubig
Copy link
Contributor

@neubig neubig commented Jul 13, 2017

@zhisbug @Abasyoni This is a first draft of GPU support. Does it look reasonable? If so, let's do max pooling as well.

neubig added 2 commits Jul 13, 2017
@neubig
Copy link
Contributor Author

@neubig neubig commented Jul 13, 2017

OK, this should be ready now?

@neubig neubig changed the title [WIP] Set conv2d to use scratch memory on gpu Set conv2d to use scratch memory on gpu Jul 13, 2017
@neubig
Copy link
Contributor Author

@neubig neubig commented Jul 13, 2017

I'm going to merge this because I'm pretty sure it's right, and would like to use this functionality.

@neubig neubig merged commit c557c77 into master Jul 13, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@zhisbug
Copy link
Collaborator

@zhisbug zhisbug commented Jul 13, 2017

@neubig Fine! Thanks.

@neubig neubig deleted the conv2d-scratch-on-gpu branch Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.