Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for CallLog.to_dict() KeyErrors #71

Merged
merged 1 commit into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@jkleint
Copy link
Contributor

jkleint commented Jun 1, 2016

I have not taken the time to really understand what CallLog is trying to do, but this seems to fix the crashes people are seeing (e.g., #65, #66).

The design of CallLog seems a bit complicated; if it's just a map of function arguments to return values, you might consider as keys a sorted tuple of key-value pairs, or a (normalized) serialization such as JSON or pickle.

@claesenm

This comment has been minimized.

Copy link
Owner

claesenm commented Jun 24, 2016

Thanks for the pull request, I will check it out ASAP.

@claesenm claesenm merged commit 019182c into claesenm:master Dec 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.