From afbc20a10540a0f433465e600b0f6ffc2288db69 Mon Sep 17 00:00:00 2001 From: Claudio Gomes da Silva Date: Tue, 24 Sep 2019 12:09:20 -0300 Subject: [PATCH 1/3] sec - fix --- pom.xml | 2 +- .../clagomess/modplsql/jdbc/Database.java | 20 ++++++++++++++----- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/pom.xml b/pom.xml index 8b5616f..6942e6e 100644 --- a/pom.xml +++ b/pom.xml @@ -47,7 +47,7 @@ 1.7.26 - + com.oracle ojdbc6 diff --git a/src/main/java/com/github/clagomess/modplsql/jdbc/Database.java b/src/main/java/com/github/clagomess/modplsql/jdbc/Database.java index 9ced5d4..ea711c4 100644 --- a/src/main/java/com/github/clagomess/modplsql/jdbc/Database.java +++ b/src/main/java/com/github/clagomess/modplsql/jdbc/Database.java @@ -32,6 +32,8 @@ public static void init(ConfigDto dto) throws SQLException { } public static String runPl(String plName, Map param) throws SQLException { + int idx; + // fill parans param.putAll(configDto.getParamsAsMap()); @@ -45,10 +47,10 @@ public static String runPl(String plName, Map param) throws SQLE sql.append(String.format(" NUM_ENTRIES := %s;\n", param.size())); - int idx = 1; + idx = 1; for (Map.Entry entry : param.entrySet()) { - sql.append(String.format(" NAME_ARRAY(%s) := '%s';\n", idx, entry.getKey())); - sql.append(String.format(" VALUE_ARRAY(%s) := '%s';\n", idx, escape(entry.getValue()))); + sql.append(String.format(" NAME_ARRAY(%s) := ?; -- '%s'\n", idx, entry.getKey())); + sql.append(String.format(" VALUE_ARRAY(%s) := ?; -- '%s'\n", idx, escape(entry.getValue()))); idx++; } @@ -63,9 +65,17 @@ public static String runPl(String plName, Map param) throws SQLE log.info("QUERY:\n{}", sql.toString()); - stmt.executeUpdate(sql.toString()); + PreparedStatement pstmt = conn.prepareStatement(sql.toString()); + idx = 1; + for (Map.Entry entry : param.entrySet()) { + pstmt.setString(idx, entry.getKey()); + idx++; + pstmt.setString(idx, entry.getValue()); + idx++; + } + + pstmt.execute(); - log.info("GET RESULT"); return getResult(); } From 7f482076c6b5d51d30251f6ed7643fb24b234d55 Mon Sep 17 00:00:00 2001 From: Claudio Gomes da Silva Date: Tue, 24 Sep 2019 12:12:29 -0300 Subject: [PATCH 2/3] sec - fix todo --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6942e6e..8b5616f 100644 --- a/pom.xml +++ b/pom.xml @@ -47,7 +47,7 @@ 1.7.26 - + com.oracle ojdbc6 From baa1e1d5f2257552ce8013b1d18e1ea65b8c9dda Mon Sep 17 00:00:00 2001 From: Claudio Gomes da Silva Date: Tue, 24 Sep 2019 12:14:22 -0300 Subject: [PATCH 3/3] sec - release 1.0.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8b5616f..f986dda 100644 --- a/pom.xml +++ b/pom.xml @@ -6,7 +6,7 @@ com.github.clagomess mod-plsql - 1.0.1 + 1.0.2 9.4.19.v20190610