Clangd shows redundant return types on some special members #252
Labels
Comments
|
Yeah, we debated this a bit for code complete but there's no question we're showing decls here rather than expressions. This seems clearcut. |
|
Oops that one somehow slipped away, thanks for bumping it up. |
kadircet
added a commit
to llvm/llvm-project
that referenced
this issue
Jan 27, 2020
Summary: Some names, e.g. constructor/destructor/conversions, already contain the type info, no need to duplicate them in the hoverinfo. Fixes clangd/clangd#252 Reviewers: sammccall, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D73110 (cherry picked from commit 1fbb1d6)
arichardson
added a commit
to arichardson/llvm-project
that referenced
this issue
Apr 1, 2020
Summary: Some names, e.g. constructor/destructor/conversions, already contain the type info, no need to duplicate them in the hoverinfo. Fixes clangd/clangd#252 Reviewers: sammccall, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D73110
shrouxm
pushed a commit
to sourcegraph/lsif-clang
that referenced
this issue
Jul 12, 2020
Summary: Some names, e.g. constructor/destructor/conversions, already contain the type info, no need to duplicate them in the hoverinfo. Fixes clangd/clangd#252 Reviewers: sammccall, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D73110 (cherry picked from commit 1fbb1d6df0113ca341f6d257bc72e07343dd861a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
Expected: the hover does not show return types.
Actual: the hover shows return type.
The text was updated successfully, but these errors were encountered: