Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Hover on constexpr expression. #56

Closed
lh123 opened this issue Jun 12, 2019 · 3 comments
Closed

[Feature Request] Support Hover on constexpr expression. #56

lh123 opened this issue Jun 12, 2019 · 3 comments
Assignees

Comments

@lh123
Copy link

@lh123 lh123 commented Jun 12, 2019

1. Hover on constexpr function.
1
2. Hover on sizeof expression.
2
3. Hover on template.
3
4. Hover on literal
4

@sam-mccall
Copy link
Member

@sam-mccall sam-mccall commented Jun 12, 2019

Great examples. Are the hovers shown from the Microsoft C++ plugin?

I believe all of these are cases of expressions that can be evaluated using Expr::EvaluateAsRValue. @kadircet, this seems like something we could add to the new structured hover?

@lh123
Copy link
Author

@lh123 lh123 commented Jun 12, 2019

Great examples. Are the hovers shown from the Microsoft C++ plugin?

Yes

@kadircet
Copy link
Member

@kadircet kadircet commented Jan 9, 2020

This is mostly done after llvm/llvm-project@287a874 except:

  • hovering over expressions like StringLiterals and sizeof/alignof
  • better printing for stringliterals
arichardson added a commit to arichardson/llvm-project that referenced this issue Jan 20, 2020
Summary:
This currently populates only the Name with the expression's type and
Value if expression is evaluatable.

Fixes clangd/clangd#56

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72500
kadircet added a commit to llvm/llvm-project that referenced this issue Jan 27, 2020
Summary:
This currently populates only the Name with the expression's type and
Value if expression is evaluatable.

Fixes clangd/clangd#56

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72500

(cherry picked from commit 4d14bfa)
shrouxm pushed a commit to sourcegraph/lsif-clang that referenced this issue Jul 12, 2020
Summary:
This currently populates only the Name with the expression's type and
Value if expression is evaluatable.

Fixes clangd/clangd#56

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72500

(cherry picked from commit 4d14bfaa2cb1610104db6b0818fc7d74fad1bd8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants