Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (6)
@hokein hokein May 9, 2023
personally, I prefer to set it `true` by default, this is more aligned with the VSCode "unnecessary code" style.
package.json
HighCommander4 GitMensch
@hokein hokein May 9, 2023
nit: can we move this section above to the `commands` section? so that all inactiveRegion settings are closer.
Outdated
package.json
@hokein hokein Apr 13, 2023
If the user changes their color theme (from `light` => `dark`), we'll not reapply the hightlights, we probably need to add a listener to handle this case, e.g. ``` this.subscriptions.push( vscode.workspace.onDidChangeConfiguration((conf) => { if (!conf.affectsConfiguration('workbench.colorTheme')) return; // reapply highlights for inactive region. })); ```
src/inactive-regions.ts
HighCommander4
@hokein hokein Apr 13, 2023
idetify => identify.
Outdated
package.json
@hokein hokein Mar 23, 2023
is there a related GitHub thread for this? If so, it would be nice to mention it (I tried to search `inactive regions proposal for LSP`, it didn't find anything).
Outdated
src/inactive-regions.ts
HighCommander4
@hokein hokein Mar 23, 2023
A native question, how do you come up with these numbers? I guess we want to follow the inactive-style of the TS in vscode, but I didn't manage to figure out the color style there (the `Developer: Inspect Editor Tokens and Scopes` command doesn't seem to give useful information there) .
Outdated
src/inactive-regions.ts
hokein HighCommander4