New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting clicolors_control #942

Closed
mitsuhiko opened this Issue Apr 25, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@mitsuhiko
Contributor

mitsuhiko commented Apr 25, 2017

I pushed up this crate because I'm a bit tired of having to configure many different things for CLI color support. What do you think of having something like this?

https://docs.rs/clicolors-control/0.1.0/clicolors_control/

The idea is that there is a standardized crate that figures out if ANSI colors are support to be used. Now that Windows 10 has ANSI color support (which that crate turns on) it seems like that might be a sensible path forward.

@kbknapp

This comment has been minimized.

Member

kbknapp commented May 6, 2017

Awesome, I like it! Yeah, I really want to rework the color control (see #836). I've looked briefly at termcolor but I haven't had much time this year due to my paid job. Since I haven't yet put a ton of research into either yet, do you happen to know how this compares to termcolor? Or are they doing completely different things?

@BurntSushi

This comment has been minimized.

Contributor

BurntSushi commented May 8, 2017

@kbknapp It seems like clicolors_control is something termcolor might want to use. For example, termcolor's interface lets you specify a preference for colors, and then it will take over from there. It could use clicolors_control to make its choice smarter. In particular, it looks like the key thing it could benefit from is automatic ANSI color support in Windows 10.

@kbknapp kbknapp referenced this issue Feb 15, 2018

Open

Tracking Issue for 3.x #1037

51 of 90 tasks complete
@kbknapp

This comment has been minimized.

Member

kbknapp commented Jul 22, 2018

I'm closing this as part of #836

@kbknapp kbknapp closed this Jul 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment