Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis CI badge #1403

Merged
merged 1 commit into from Mar 27, 2019
Merged

Fix Travis CI badge #1403

merged 1 commit into from Mar 27, 2019

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jan 1, 2019

No description provided.

spacekookie
spacekookie reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@spacekookie spacekookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, do you want to rebase this branch against master?

@rhysd
Copy link
Contributor Author

rhysd commented Mar 26, 2019 •
edited

Since this branch was created on GitHub web, I didn't clone this repo on my local. I clicked 'Update branch' button and it merged master.

EDIT: I rebased onto latest master at f6b9d41

spacekookie
spacekookie approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@spacekookie spacekookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Since the CI failure is unrelated (and currently just sad on master I'll merge this anyway

@spacekookie spacekookie merged commit d3ec625 into clap-rs:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacekookie spacekookie spacekookie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhysd @spacekookie