fix(parser): Rely on default_missing_value for flag actions #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple values can only happen from env variables when configured by the user, so let's not go out of our way to deal with it.
In the short term, this just provides a back door to custom actions. Longer term, we can explore a `SetConst` action that relies on this behavior. Really, `SetTrue` and `SetFalse` are shortcuts for such an action but shortcuts can be helpful for usability. Apparently, this also reduced `.text` size by 1k
epage
added a commit
to epage/clap
that referenced
this pull request
Aug 19, 2022
Not sure if we could have originally made this work but it definitely does now that we use `default_missing_value` for this (clap-rs#4000)
Calder-Ty
pushed a commit
to Calder-Ty/clap
that referenced
this pull request
Aug 24, 2022
Not sure if we could have originally made this work but it definitely does now that we use `default_missing_value` for this (clap-rs#4000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the short term, this just provides a back door to custom actions.
Longer term, we can explore a
SetConstaction that relies on thisbehavior. Really,
SetTrueandSetFalseare shortcuts for such anaction but shortcuts can be helpful for usability.
Apparently, this also reduced
.textsize by 1k