Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Make ArgAction::Set the default #4032

Merged
merged 6 commits into from Aug 6, 2022
Merged

fix!: Make ArgAction::Set the default #4032

merged 6 commits into from Aug 6, 2022

Conversation

epage
Copy link
Member

@epage epage commented Aug 5, 2022

This removes the need for TakesValue bookkeeping for when we knew we
took values but didn't know how many we should take.

Fixes #2687

Naming is hard.  I found I was writing new code without the `s` so that
suggests the name was wrong.  But we renamed `number_of_values` to
`num_args`, so should this be `ArgRange`?
This removes the need for `TakesValue` bookkeeping for when we knew we
took values but didn't know how many we should take.

Fixes clap-rs#2687
Because of our changes from v3, we can't rely on `_build` taking care of
this for us.
@epage epage merged commit 179faa6 into clap-rs:master Aug 6, 2022
20 checks passed
@epage epage deleted the flag branch August 6, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove magic arg type in Args
1 participant