Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Support Option when flattening #4350

merged 5 commits into from Oct 5, 2022


Copy link

@epage epage commented Oct 5, 2022

Fixes #3123

If the inner type never implemented `group_id()`, then it won't work and
people will be confused.  This at least gives people an idea of whats
going wrong.

This is most likely to be a problem until clap-rs#3165 is fully implemented but
hand-implementations can still run into this.  Probably should have made
the groups another trait to catch this in type system but too late.
@epage epage mentioned this pull request Oct 5, 2022
2 tasks
@epage epage merged commit f86cd0f into clap-rs:master Oct 5, 2022
19 of 20 checks passed
@epage epage deleted the option branch October 5, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

derive: flatten on Option fields
1 participant