feat(derive): Allow type-less fields #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When overriding other fields, help or version flag, globals, etc, a user might not care about the value, so let's ignore the lookup. Been talking about this for a while but Issue clap-rs#4367 moved this forward because there wasn't a good way to handle this without changing behavior.
2 tasks
wfxr
added a commit
to hackathon-2022-ticli/ticli
that referenced
this pull request
Oct 21, 2022
clap-rs/clap#4367 clap-rs/clap#4371 Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
tmccombs
added a commit
to tmccombs/fd
that referenced
this pull request
Nov 11, 2022
As now supported by clap-rs/clap#4371 and clap-rs/clap#4459
tmccombs
added a commit
to tmccombs/fd
that referenced
this pull request
Nov 11, 2022
As now supported by clap-rs/clap#4371 and clap-rs/clap#4459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When overriding other fields, help or version flag, globals, etc, a user might not care about the value, so let's ignore the lookup.
Been talking about this for a while but Issue #4367 moved this forward because there wasn't a good way to handle this without changing behavior.