Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wasm32 targets with is-terminal #4518

merged 2 commits into from Nov 29, 2022


Copy link

@pinkforest pinkforest commented Nov 29, 2022

Fixes #4510

Note: terminal_size is using old version of rustix and this causes a bit dependency duplication.

Will check to bump upstream. EDIT: Someone already did - eminence/terminal-size#46 (needs a release)

Copy link
Contributor Author

Builds fine -

CI is now blocked on testing issues: #4510 (comment)

Copy link

epage commented Nov 29, 2022

I pulled #4515 out of this so we don't block fixing production code based on tests

@epage epage merged commit 2ad0eff into clap-rs:master Nov 29, 2022
19 of 20 checks passed
@pinkforest pinkforest deleted the fix-wasm32-attempt2 branch November 29, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Recent minor version upgrade of clap breaks building with a wasm target.
2 participants