refactor: Split out clap_builder for faster derive builds #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we are still treating `clap` as the user facing API for both builder and derive, making this an internal change as we don't expect this to negatively impact builder build times all that much. We can re-evaluate at a later time and consider having distinct top-level crates for builder and derive. Looking at `--timings` on my machine - `clap` only took 0.04s to build and it happened in parallel to `clap_builder` codegen - this saved 1.7s for derive build times, with `clap_builder` building in parallel to `syn` and `clap_builder` and `clap_derive` finishing around the same time. This was discussed some at https://rust-lang.zulipchat.com/#narrow/stream/220302-wg-cli/topic/clap.20build.20times.20and.20.60clap_derive.60.3A.20a.20crazy.20idea
epage
force-pushed
the
builder
branch
5 times, most recently
from
ad14b40
to
4e1a565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we are still treating
clapas the user facing API for both builder and derive, making this an internal change as we don't expect this to negatively impact builder build times all that much. We can re-evaluate at a later time and consider having distinct top-level crates for builder and derive.Looking at
--timingson my machineclaponly took 0.04s to build and it happened in parallel toclap_buildercodegenclap_builderbuilding in parallel tosynandclap_builderandclap_derivefinishing around the same time.This was discussed some at https://rust-lang.zulipchat.com/#narrow/stream/220302-wg-cli/topic/clap.20build.20times.20and.20.60clap_derive.60.3A.20a.20crazy.20idea