Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(help): Allow customizing terminal styling (unstable) #4843

Merged
merged 13 commits into from
Apr 18, 2023

Conversation

epage
Copy link
Member

@epage epage commented Apr 18, 2023

This is a step towards #3234 while allowing collecting of feedback

Code size

via cargo bloat --release --features cargo --example cargo-example

epage added 11 commits April 18, 2023 15:22
Random fixes along the way
- In one case the space after `tip:` was "colored" (won't matter until
  themeing is available)
- One error case didn't color invalid values
- Changed the args associated with invalid values to be `literal` rather
  than `warning`
- Changed the required value count to be `good`
- Changed the arg for invalid value counts to be `literal` (the actual
  count is `warning`)
For now, this is behind the `unstable-styles` feature as we verify this
is what we want for clap-rs#3224
Because this doesn't have a full section after it, people might want to
style it differently than other headers.
We can add a new style and default it to what it was split out of
without a breaking change.
@epage epage merged commit b0e0c59 into clap-rs:master Apr 18, 2023
@epage epage deleted the style branch April 18, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant