Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (fish-completion) Help for value enum #5114

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

jporwal05
Copy link
Contributor

Resolves: #5101

  • The completion of value enums now displays accurate help text
  • This fix encloses help text in single quotes
  • Any text after tab is taken as help text
  • Comma in help text is not escaped
  • This is because the the help text is now treated as literal
  • No variable expansion or command substitution in help text

- Breaking for fish shell
- Matching the bad output to make the test pass
Resolves clap-rs#5101

- The completion of value enums now displays accurate help text
- This fix encloses help text in single quotes
- Any text after tab is taken as help text
- Comma in help text is not escaped
- This is because the the help text is now treated as literal
- No variable expansion or command substitution in help text
@epage
Copy link
Member

epage commented Sep 7, 2023

Thanks!

@epage epage merged commit 1509828 into clap-rs:master Sep 7, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parentheses in doc comments for ValueEnum break generated fish completions
2 participants