Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update terminal_size to 0.3.0 #5129

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

cgwalters
Copy link
Contributor

@cgwalters cgwalters commented Sep 18, 2023

For some reason, terminal_size bumped semver recently; they also bumped the rustix version to 0.38.

I'd like to reduce the number of copies of OS integration crates (rustix and nix) in my dependency chain. By updating terminal_size to 0.3.x we allow builders to keep then number of dependencies to a minimum

(Now honestly, given terminal_size boils down to basically
one function I have no idea why they bumped semver, the
API appears to be the same because we continue to build
with both, as you'd expect)

@cgwalters cgwalters changed the title builder: Widen terminal_size compat to include 3.0 chore: builder: Widen terminal_size compat to include 3.0 Sep 18, 2023
clap_builder/Cargo.toml Outdated Show resolved Hide resolved
For some reason, terminal_size bumped semver recently; they
also bumped the rustix version to 0.38.

I'd like to reduce the number of copies of OS integration
crates (rustix and nix) in my dependency chain.  Let's bump
to the new version so I can aim to drop rustix 0.37.
@epage epage changed the title chore: builder: Widen terminal_size compat to include 3.0 chore: Update terminal_size to 0.3.0 Sep 18, 2023
@epage epage merged commit f09d521 into clap-rs:master Sep 18, 2023
24 checks passed
@tshepang
Copy link
Contributor

(Now honestly, given terminal_size boils down to basically one function I have no idea why they bumped semver, the API appears to be the same because we continue to build with both, as you'd expect)

I see this on release notes:

Note that this is a subtle change in behavior, since the terminal_size() function will now return success in cases more cases than before. For example, if your command had stdout redirected to a file, terminal_size() used to return nothing, and now it returns a size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants