New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use the atty crate for isatty() detection #862

Merged
merged 1 commit into from Feb 19, 2017

Conversation

Projects
None yet
4 participants
@pkgw
Contributor

pkgw commented Feb 19, 2017

Not only does this remove some unsafe code from clap itself, atty does the right thing on Windows too. This isn't relevant now since we don't currently support colorized output on Windows, but will come in handy if/when we implement that feature (#836).

refactor: use the atty crate for isatty() detection
Not only does this remove some unsafe code from clap itself, `atty` does the
right thing on Windows too. This isn't relevant now since we don't currently
support colorized output on Windows, but will come in handy if/when we
implement that feature (#836).
@coveralls

This comment has been minimized.

coveralls commented Feb 19, 2017

Coverage Status

Coverage decreased (-0.05%) to 90.609% when pulling 68e0368 on pkgw:pr-atty into 6f9a0ba on kbknapp:master.

@kbknapp

This comment has been minimized.

Member

kbknapp commented Feb 19, 2017

Excellent thanks!

@homu r+

@homu

This comment has been minimized.

Collaborator

homu commented Feb 19, 2017

📌 Commit 68e0368 has been approved by kbknapp

homu added a commit that referenced this pull request Feb 19, 2017

Auto merge of #862 - pkgw:pr-atty, r=kbknapp
refactor: use the atty crate for isatty() detection

Not only does this remove some unsafe code from clap itself, `atty` does the right thing on Windows too. This isn't relevant now since we don't currently support colorized output on Windows, but will come in handy if/when we implement that feature (#836).
@homu

This comment has been minimized.

Collaborator

homu commented Feb 19, 2017

⚡️ Test exempted - status

@homu homu merged commit 68e0368 into clap-rs:master Feb 19, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 90.609%
Details
homu Test exempted
Details

@pkgw pkgw deleted the pkgw:pr-atty branch Feb 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment