New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(help): don't show ARGS when there are only hidden positional args #884

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@andete
Contributor

andete commented Mar 3, 2017

Also no need to check for Hidden inside for that already is filtered
on !Hidden.

Closes #882

fix(help): don't show ARGS when there are only hidden positional args
Also no need to check for Hidden inside for that already is filtered
on !Hidden.

Closes #882
@coveralls

This comment has been minimized.

coveralls commented Mar 3, 2017

Coverage Status

Coverage increased (+0.01%) to 91.566% when pulling 55c11c0 on andete:all_args_hidden into 7b08a0a on kbknapp:master.

@kbknapp

This comment has been minimized.

Member

kbknapp commented Mar 9, 2017

Thanks! Sorry for the long response, I've been traveling for work. I've merged your commit into my bigger rollup PR (#893)

@kbknapp kbknapp closed this Mar 9, 2017

@andete andete deleted the andete:all_args_hidden branch Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment