Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation links in Windows build of site #9

Closed
claremacrae opened this issue Apr 1, 2019 · 8 comments

Comments

Projects
None yet
1 participant
@claremacrae
Copy link
Owner

commented Apr 1, 2019

  • site.github.is_project_page is True
  • site.github.is_user_page

This means that the links on the left hand side are for a project page, not the customised links to Blog and About, that I was expecting to see

@claremacrae claremacrae added the bug label Apr 1, 2019

@claremacrae

This comment has been minimized.

@claremacrae claremacrae self-assigned this Apr 1, 2019

@claremacrae

This comment has been minimized.

@claremacrae

This comment has been minimized.

Copy link
Owner Author

commented Apr 1, 2019

Running the following command....

bundle exec jekyll build --verbose

... includes the following output:

   GitHub Metadata: Generating for claremacrae/claremacrae.github.io
   GitHub Metadata: No GitHub API authentication could be found. Some fields may be missing or have incorrect data.

Which may explain the problem.

@claremacrae

This comment has been minimized.

Copy link
Owner Author

commented Apr 1, 2019

@claremacrae

This comment has been minimized.

Copy link
Owner Author

commented Apr 1, 2019

Adding this to my _config.yml did not make the warning go away.

github: [metadata]

@claremacrae

This comment has been minimized.

Copy link
Owner Author

commented Apr 1, 2019

@claremacrae

This comment has been minimized.

Copy link
Owner Author

commented Apr 1, 2019

Some progress:
Following the Fix “The GitHub API credentials you provided aren’t valid.” section of this page got rid of that warning when building the site:

http://blog.johannesmp.com/2017/02/13/fixing-jekyll-serve-on-windows/

  • So now site.github.is_project_page appears to be false
  • But unfortunately site.github.is_user_page is also false

So I now get no links at all in the navigation area.

claremacrae added a commit that referenced this issue Apr 1, 2019

Tyring to track down site.github problems - see #9
site.github values differ between my PC and the deployed site

claremacrae added a commit that referenced this issue Apr 1, 2019

@claremacrae

This comment has been minimized.

Copy link
Owner Author

commented Apr 5, 2019

This is now fixed - see d8612ae

@claremacrae claremacrae closed this Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.