Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopEntity annotation documentation is missing Enable parameter #646

Closed
gergoerdi opened this issue Jun 25, 2019 · 0 comments
Closed

TopEntity annotation documentation is missing Enable parameter #646

gergoerdi opened this issue Jun 25, 2019 · 0 comments
Labels
bug

Comments

@gergoerdi
Copy link
Contributor

The TopEntity annotation documentation in Clash.Annotations.TopEntity never mentions the Enable dom parameter that seems to be required by the new exposeClockResetEnable, and none of the examples have any t_inputs entry for them.

I don't know what the correct documentation should be, since I myself don't understand yet what this extra parameter is for. By experimenting, it seems I need to add it to t_inputs and feed it with constant high signal.
@leonschoorl leonschoorl mentioned this issue Jun 28, 2019
Closed
leonschoorl pushed a commit that referenced this issue Apr 6, 2021
@christiaanb @leonschoorl
Update TopEntity annotation docs to include Enable parameter
3dbbf7c 
Also fixes all the examples and updates their shown outputs.

Fixes #646
Fixes #654
@leonschoorl leonschoorl mentioned this issue Apr 6, 2021
Merged
mergify bot pushed a commit that referenced this issue Apr 7, 2021
@christiaanb
Update TopEntity annotation docs to include Enable parameter
aff81aa 
Also fixes all the examples and updates their shown outputs.

Fixes #646
Fixes #654

(cherry picked from commit ca8ad0e)
martijnbastiaan pushed a commit that referenced this issue Apr 7, 2021
@christiaanb @martijnbastiaan
Update TopEntity annotation docs to include Enable parameter
13644f3 
Also fixes all the examples and updates their shown outputs.

Fixes #646
Fixes #654

(cherry picked from commit ca8ad0e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gergoerdi @martijnbastiaan