Black Boxes for toEnum / fromEnum
#2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running GHC with -Werror, that option is now propagated to the ClashOpts. This means that warnings on primitive instantiation will be promoted to errors. This is necessary to test #2046.
DigitalBrains1
requested changes
Jan 31, 2022
alex-mckenna
force-pushed
the
issue-2046
branch
5 times, most recently
from
0a9a4da
to
12217de
Compare
alex-mckenna
force-pushed
the
issue-2046
branch
from
12217de
to
3667ed9
Compare
martijnbastiaan
requested changes
Feb 2, 2022
| @@ -0,0 +1 @@ | |||
| CHANGED: Clash now respects the -Werror option from GHC | |||
DigitalBrains1
approved these changes
Feb 2, 2022
alex-mckenna
force-pushed
the
issue-2046
branch
2 times, most recently
from
06d032a
to
f0ef6cc
Compare
|
@martijnbastiaan I added a |
martijnbastiaan
force-pushed
the
issue-2046
branch
from
f0ef6cc
to
db50776
Compare
alex-mckenna
commented
Feb 2, 2022
Comment on lines
9
to
11
| , (BitVector 1, BitVector 2) | ||
| ) |
There was a problem hiding this comment.
Can you test Bit too, one of the functions changed for that
There was a problem hiding this comment.
iverilog (make testBench): FAIL (0.04s)
Program /usr/bin/iverilog failed with error-code 2.
Full invocation:
/usr/bin/iverilog -I T2046BType.o -I T2046B.dyn_hi -I T2046B.hi -I T2046B.testBench -I T2046BType.dyn_o -I T2046BType.dyn_hi -I T2046B.topEntity -I T2046B.dyn_o -I T2046BType.hi -I T2046B.o -g2 -s testBench -o testBench.exe /tmp/clash-test-b57a279493374e3d/T2046B.testBench/testBench.v /tmp/clash-test-b57a279493374e3d/T2046B.topEntity/topEntity.v
Stderr was:
/tmp/clash-test-b57a279493374e3d/T2046B.topEntity/topEntity.v:98: syntax error
/tmp/clash-test-b57a279493374e3d/T2046B.topEntity/topEntity.v:98: error: syntax error in continuous assignment
Stdout was:
db50776
to
22df733
Compare
alex-mckenna
force-pushed
the
issue-2046
branch
from
22df733
to
f65e779
Compare
To prevent Clash from warning about integer primitives in HDL that originate from uses of fromEnum / toEnum in user code, the functions are now primitives for the sized types in Clash.
alex-mckenna
force-pushed
the
issue-2046
branch
from
f65e779
to
0613f21
Compare
martijnbastiaan
approved these changes
Feb 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces black boxes for
toEnum/fromEnumon the numeric types inClash.Sized.Internal, suppressing the seemingly spurious integer black box warnings previously seen in #1918. As an added bonus, a commit is included which propagates the-Werrorflag from GHC to Clash, allowing primitive warnings to be thrown asClashExceptionwhen desired.Fixes #2046
Still TODO:
toEnum, the current test usesfromEnumonly