Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for unary arithmetic functions #11

Merged
merged 4 commits into from Feb 7, 2017

Conversation

Projects
None yet
2 participants
@nshepperd
Copy link
Contributor

commented Feb 5, 2017

I wanted a type level logarithm for some experiments, so I've implemented support for unary functions here. Previously, one could make a two-argument function that just didn't make use of its argument, but it looks messier than directly implementing one-argument function.

Also, I added a proptest for it (using QuickCheck) since that seemed easiest, and then some other proptests while I was trying to debug... Whether you want to keep the tests that way is up to you.

@christiaanb
Copy link
Contributor

left a comment

LGTM.

Could you add a line to the changelog as well? Thanks.

@nshepperd nshepperd force-pushed the nshepperd:unary branch from 8710f63 to b2af8bd Feb 7, 2017

@nshepperd

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2017

Wait, do you want the version bumped too? Or I can just add an entry at the top under version HEAD or something, so you can bump the version later.

@christiaanb christiaanb merged commit a5ed8d8 into clash-lang:master Feb 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@christiaanb

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2017

This is fine. Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.