Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized versions for feature parity #328

Open
classilla opened this issue Sep 11, 2016 · 64 comments
Open

Localized versions for feature parity #328

classilla opened this issue Sep 11, 2016 · 64 comments
Assignees

Comments

@classilla
Copy link
Owner

@classilla classilla commented Sep 11, 2016

This will involve custom strings.

See #42 for history.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jan 8, 2018

Updated Locale installers with copyright 2018, fix for print/open/save dialogs and allowing for 'FPRx.y' version strings up to FPR10.5 in the version check routine. I did not use placeholders so we can easily exclude earlier versions of the browser when new custom strings or other changes are introduced that would make the installers incompatible with these versions. Also renamed the installers to show 'FPR' since '45' probably confuses people by now.

TFF-FPR.x-Langpack-Finnish.app.zip
TFF-FPR.x-Packlangage-Français.app.zip
TFF-FPR.x-Sprachpaket-Deutsch.app.zip
TFF-FPR.x-Langpack-Italiano.app.zip
TFF-FPR.x-Polski_pakiet_jezykowy.app.zip
TFF-FPR.x-Langpack-Russian.app.zip
TFF-FPR.x-Langpack-Spanish.app.zip
TFF-FPR.x-Langpack-Swedish.app.zip

@chris-chtrusch chris-chtrusch self-assigned this Jan 8, 2018
@classilla
Copy link
Owner Author

@classilla classilla commented Jan 9, 2018

@classilla
Copy link
Owner Author

@classilla classilla commented Jan 24, 2018

Replaced on home page.

@nemanjacosovic
Copy link

@nemanjacosovic nemanjacosovic commented Feb 22, 2018

How could one join in on translating TFF?

@classilla
Copy link
Owner Author

@classilla classilla commented Feb 23, 2018

Look at https://github.com/classilla/tenfourfox/wiki/Localization . If you feel able to do so, post the pack as an attachment here and we can get it processed for general availability.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Mar 11, 2018

There are slight changes in the About Dialog credits/contributers list starting with FPR6. Modified the German installer accordingly. I think it should be sufficient to slip this in for all installers on occasion when something else needs to be fixed or updated.
TFF-FPR.x-Sprachpaket-Deutsch.app.zip

@classilla
Copy link
Owner Author

@classilla classilla commented Mar 11, 2018

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Mar 12, 2018

The key is <!ENTITY contribute.start … and yes, there's some English in it.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jun 18, 2018

Localizations need updates for samesite cookie support in the developer tools.
Line 'table.headers.cookies.sameSite=sameSite' is missing in 45 based localizations in storage.properties. Since the string 'same site' doesn't seem to be translated in FF60 localizations anyway (checked DE, FR, IT), I'll just copy that line over from TFF FPR8b1.

At the same time I'll update the version checker for versions >FPR10 because we're getting near that number, and remove support for <FPR8. We should keep an archive of the installers valid for up to FPR 7.

Also I'll update contributers in the about dialog.

Will post installers here shortly.

@classilla
Copy link
Owner Author

@classilla classilla commented Jun 18, 2018

@classilla
Copy link
Owner Author

@classilla classilla commented Jun 26, 2018

Uploaded and live.

@PowerOlive
Copy link

@PowerOlive PowerOlive commented Jan 31, 2019

will it be a chinese version?

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jan 31, 2019

It can be done. Do you mean Simplified or Traditional Chinese?

The problem is that, unlike Latin, Cyrillic and a little Greek, I'm illiterate in Chinese. I need a volunteer (native speaker if possible) to do quality control and translate a few text strings for functionality that is only in TenFourFox, not in Firefox. Can you do this?

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Apr 1, 2019

I need to update the © date in the about dialog, also update the version checker for TFF 14ff. While I'm at it: Any new strings to add?

@paizhangpi
Copy link

@paizhangpi paizhangpi commented Apr 1, 2019

It can be done. Do you mean Simplified or Traditional Chinese?

The problem is that, unlike Latin, Cyrillic and a little Greek, I'm illiterate in Chinese. I need a volunteer (native speaker if possible) to do quality control and translate a few text strings for functionality that is only in TenFourFox, not in Firefox. Can you do this?

I'm native speaker, 2 years user of TFF and glad to help the translation of TFF in Simplified Chinese. https://github.com/classilla/tenfourfox/wiki/Localization I read that but it's quite hard for me to understand. Could you please guide me to join the translation if there's a easier way

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Apr 1, 2019

Paizhangpi, I'm just going to need the strings in the attached text file translated to Simplified Chinese, then I can start making the installer app. Thank you!
strings to translate.txt

@paizhangpi
Copy link

@paizhangpi paizhangpi commented Apr 1, 2019

(The Applescript dialogs will have to stay English because Applescript for 10.4 doesn't support non-ascii characters.)
(AppleScript对话框将使用英文,因为Mac OS X 10.4的AppleScript不支持非ASCII字符。)

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Apr 1, 2019

Thank you! I will make the installer during the next weekend. I'll try to use the complete sentence in the About Tenfourfox dialog, I suspected such a problem :-)

I forgot this string for the About Tenfourfox dialog:
Mozilla Community Credits

@paizhangpi
Copy link

@paizhangpi paizhangpi commented Apr 1, 2019

That's no problem at all. TenFourFox let my powerful PowerPC Mac reborn, so I'm happy to join the translation of my native language. Feel free to contact me for further problem.
the message is from TenFourFox running on my QUAD G5.

Mozilla Community Credits
Mozilla 社区贡献者列表

@classilla
Copy link
Owner Author

@classilla classilla commented Apr 2, 2019

I need to update the © date in the about dialog, also update the version checker for TFF 14ff. While I'm at it: Any new strings to add?

If the MP4 stuff sticks, we might expose that pref. I haven't decided yet, but an "Enable H.264 video" couldn't hurt, I suppose. It's not critical however.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Apr 2, 2019

Alright, I'll add these; since the grammar should be consistent and we have enough other things that can be 'enabled' I could even translate this myself. I'm planning to upload all new installers incl. Chinese on the weekend.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Apr 6, 2019

Cameron, can we go with

ENTITY TFFh264.title "H.264 video"
ENTITY TFFh264.prompt "Enable H.264 video"

in TenFourFox.dtd, and

TFFh264.title.p = H.264 video
TFFh264.prompt.p = Enable H.264 video

in TenFourFox.properties?

@classilla
Copy link
Owner Author

@classilla classilla commented Apr 6, 2019

I was thinking about that. I think it might be better for the prompt to be

"Enable H.264 video (requires MP4 Enabler)"

but I don't know how feasible that would be with the extra localization phrase. Your call.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Apr 6, 2019

I'll leave the parentheses in English if I'm unsure and change it in a later edition, it's not being exposed right now anyway.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Apr 6, 2019

@classilla
Copy link
Owner Author

@classilla classilla commented May 18, 2019

I got it, thanks. Unfortunately I'm doing most of the work on Github from the Talos now for that reason. I'm cautiously hopeful about the async/await patch, but we'll see.

@classilla
Copy link
Owner Author

@classilla classilla commented May 21, 2019

All new localizations (including Simplified Chinese, thank you, @paizhangpi ) are uploaded and live.

@skippingrock
Copy link

@skippingrock skippingrock commented Jun 27, 2019

What is involved to translate it into Korean? Where do we find the strings to translate?
Bit of a n00b with GitHub, but willing to help.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jun 27, 2019

Hello skippingrock, a Korean localization would be great.

We need the following to be translated:

  1. Text strings from the file 'strings to translate.txt' attached to this comment:
    #328 (comment)

  2. Additionally we need these strings:

'Mozilla Community Credits'
'H.264 video'
'Enable H.264 video (requires MP4 Enabler)'

  1. For the website tenfourfox.com ('We speak your language') this text needs to be translated, the section in [ ] will contain the link to the installer file:

'TenFourFox speaks your language. To install Korean support in TenFourFox FPR, [download this installer], unzip it, and double click the installer to begin.'

@twse
Copy link

@twse twse commented Jun 29, 2019

Hi Chris Trusch,

I've translated all strings to Korean and Turkish (see the attachments). All attachments are using macOS line endings.
strings to translate (ko).txt
strings to translate (tr).txt

The following strings are also translated:

Mozilla Community Credits

  • Korean - 모질라 커뮤니티 기여자 목록
  • Turkish - Mozilla topluluk katkıda bulunanlar listesi

H.264 video

  • Korean - H.264 비디오
  • Turkish - H.264 video

Enable H.264 video (requires MP4 Enabler)

  • Korean - H.264 비디오 활성화 (MP4 Enabler 필요)
  • Turkish - H.264 video aç (MP4 Enabler bekleniyor)

TenFourFox speaks your language.

  • Korean - 텐포폭스는 여러분의 언어를 구사합니다.
  • Turkish - TenFourFox dilini konuşuyor.

To install [Korean/Turkish] support in TenFourFox FPR, [download this installer], unzip it, and double click the installer to begin.

  • Korean - TenFourFox FPR에 한국어 지원을 설치하려면 [이 설치 패키지를 다운로드하고] 압축을 풀고 설치 패키지를 두 번 클릭하여 시작하십시오.
  • Turkish - TenFourFox FPR'de Türkçe desteği yüklemek istiyorsanız, [bu yükleme paketini indirin], unzip yapın ve başlamak için yükleme paketini çift tıklatın.

It needs the installer packages created for Korean and Turkish.

@classilla
Copy link
Owner Author

@classilla classilla commented Jun 29, 2019

Hey, thanks!

Chris, when you've compiled them, send me an E-mail and I'll give you an alternative upload link that will send them directly to me (unless you have another system that can attach them).

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jun 29, 2019

Thank you, that was more than I expected :-) I will make the installers next week.

텐포폭스는 플러드갭 시스템에서 지원하는 무료 소프트웨어입니다.
Can you mark where "TenFourFox" and "Floodgap Systems" are located in this sentence? These will need to stay in Roman characters since they're filled in by the browser itself; I can juggle the parts around so the word order will be correct but I need to know which is which.

@twse
Copy link

@twse twse commented Jun 30, 2019

Hi Chris Trusch.

I changed TenFourFox and Floodgap Systems in the Korean translation to use Latin characters.
strings to translate (ko).txt

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jun 30, 2019

Thank you so much. I don't know what the conventions in Korean are, but would it be acceptable to exchange all instances of 텐포폭스 for TenFourFox (Roman) (with or without article 는)? As it stands now, it's a bit inconsistent. And: Which flag(s) do you feel we should use for the Korean installer app?

@classilla
Copy link
Owner Author

@classilla classilla commented Jun 30, 2019

If we have any North Korean users, I'll be impressed.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jul 5, 2019

Korean installer's ready to test. I left everything as it was translated originally. Turkish installer tomorrow.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jul 6, 2019

Cameron: I uploaded the Turkish installer and a corrected version of the Korean installer (fixed bug in localization of add-ons) to the private link.

To keep the Turkish word order in the About TenFourFox Dialog I had to use an invisible n space character (UTF#2002) to separate the parts left and right of <!ENTITY community.start2 since a normal space wouldn't do, it would then read 'TenFourFoxFloodgap Systems tarafından desteklenen ücretsiz bir yazılımdır.' This is the first language we have that has nothing in this slot, tested in 10.4 and 10.5, but please re-test whether it's displayed correctly.

@classilla
Copy link
Owner Author

@classilla classilla commented Jul 6, 2019

Can you upload them again one more time? I see the uploads were attempted but there are no files. I saw the Korean one come through yesterday but somehow that disappeared as well.

@classilla
Copy link
Owner Author

@classilla classilla commented Jul 6, 2019

Okay, I'm an idiot. I was looking at the wrong folder.

Which one do you want me to upload, .app.zip or .zip?

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jul 6, 2019

…the .zip, please. (I changed the file names this time – minus .app – in case your system was caching or overwriting something for the uploads.)

@classilla
Copy link
Owner Author

@classilla classilla commented Jul 6, 2019

The files check out (zips test fine).

@classilla
Copy link
Owner Author

@classilla classilla commented Jul 6, 2019

Korean and Turkish uploaded to https://sourceforge.net/projects/tenfourfox/files/langpacks/FPR14/ . It may take a few minutes to be mirrored. If they check out, I will link them from the main page.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jul 13, 2019

@twse & @skippingrock, can you have a look at the langpack installers for Turkish and Koeran? They should be checked by native speakers before they go live. Thanks!

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Nov 23, 2019

Cameron, would you consider releasing Korean and Turkish without being checked by native speakers, or should we just let them sit here for the time being?

@classilla
Copy link
Owner Author

@classilla classilla commented Nov 23, 2019

I don't mind. If we don't hear anything between now and FPR17's final release date, I'll make them live from the main site.

@classilla
Copy link
Owner Author

@classilla classilla commented Dec 21, 2019

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Jan 7, 2020

…bump :)

@classilla
Copy link
Owner Author

@classilla classilla commented Jan 8, 2020

Sorry. Done!

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Mar 25, 2020

The version compatibility checker in the installer's AppleScript didn't anticipate the four-week update cycle and will soon run out of valid version numbers (after 45.32). I'd like to extend this to 45.40 (or higher?).

While I'm at it I can also update the © date to 2020. Anything else?

@classilla
Copy link
Owner Author

@classilla classilla commented Mar 25, 2020

Can it be 45.99? Then this shouldn't need updating.

We should try to do the TLS/1.3 translations too but only if you think you can get the strings for all the languages. If you can't, we could duplicate some of the keys to emulate what the browser does now. See https://github.com/classilla/tenfourfox/blob/fae264c81914f799f5aa1216fb0c39a0c09a9bf7/netwerk/locales/en-US/necko.properties under 12 and 13. Right now we just make those the same as 7.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Mar 26, 2020

If you mean this:

12=Performing a TLS handshake to %1$S…
13=The TLS handshake finished for %1$S…

-> These strings are here: https://pontoon.mozilla.org/
(e.g. for German https://pontoon.mozilla.org/de/firefox/netwerk/necko.properties/?string=163853)*

I'll simply look them up for each language and put them into our necko.properties, shouldn't be a problem.

*This works only in LWK, TFF has 'TypeError: arguments is not iterable' which I've been seeing more often lately.

@classilla
Copy link
Owner Author

@classilla classilla commented Mar 26, 2020

Yes, those strings.

That's a good testcase. I just opened up a new issue. It looks like an easy fix, but I'll hold it over for FPR22.

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Mar 26, 2020

Are 12 & 13 the only new strings for TLS 1.3? If so, I got the strings for all languages and will update the installers shortly.

@classilla
Copy link
Owner Author

@classilla classilla commented Mar 27, 2020

Sorry, thought I pressed Comment and did it. Yes, those are the only new strings, see fae264c

@chris-chtrusch
Copy link
Collaborator

@chris-chtrusch chris-chtrusch commented Mar 28, 2020

Uploaded 11 langpack installers for FPR 21 and up (to 45.99) at the usual place, with the new TLS 1.3 strings included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.