New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and use vmx_strchr() #440

Open
classilla opened this Issue Sep 29, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@classilla
Owner

classilla commented Sep 29, 2017

Like it says. Not as dramatic as memchr but should still improve things.

classilla added a commit that referenced this issue Sep 29, 2017

classilla added a commit that referenced this issue Nov 16, 2017

@classilla

This comment has been minimized.

Show comment
Hide comment
@classilla

classilla Nov 16, 2017

Owner

The network code caused JPEG artifacts on Macintosh Repository, probably due to bad HTTP chunking. Disabling it and flushing the cache removed the artifacts. I suspect the problem is the first vec_* can see the same character in adjacent strings and fails to see the null terminator. We probably need a second check that sees if there is both the search character and the null, and chooses a terminal bytewalker based on that.

Owner

classilla commented Nov 16, 2017

The network code caused JPEG artifacts on Macintosh Repository, probably due to bad HTTP chunking. Disabling it and flushing the cache removed the artifacts. I suspect the problem is the first vec_* can see the same character in adjacent strings and fails to see the null terminator. We probably need a second check that sees if there is both the search character and the null, and chooses a terminal bytewalker based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment