New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opaque origins for data: URIs [M1324406/M1365166] #525

Open
classilla opened this Issue Sep 26, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@classilla
Owner

classilla commented Sep 26, 2018

This was landed in Fx57 and doesn't seem to have any regressions (most of the deps are test-related). We should use the modifications in M1365166 so that it matches current Firefox.

https://bugzil.la/1365166

@classilla

This comment has been minimized.

Owner

classilla commented Sep 27, 2018

M1381761 doesn't seem to apply, so skipping that. https://hg.mozilla.org/integration/mozilla-inbound/rev/adf6435ac760

@roytam1

This comment has been minimized.

roytam1 commented Oct 13, 2018

Just got a report that security.data_uri.unique_opaque_origin=true can cause some extensions stopped working:
https://msfn.org/board/topic/177125-my-build-of-new-moon-temp-name-aka-pale-moon-for-xp/?do=findComment&comment=1155410

@classilla

This comment has been minimized.

Owner

classilla commented Oct 13, 2018

Please, if you're going to use patches from here, at least read the development blog. This very issue is being discussed there as I write this.

@roytam1

This comment has been minimized.

roytam1 commented Oct 13, 2018

This very issue is being discussed there as I write this.

I did read, but you mentioned sites, not extensions.

@classilla

This comment has been minimized.

Owner

classilla commented Oct 13, 2018

"This middle ground should reduce issues with the older codebase and add-on compatibility problems, but it is possible some historical add-ons may be affected by this and some sites may behave differently."

Also see the comments in that blog post.

@classilla

This comment has been minimized.

Owner

classilla commented Oct 18, 2018

Preffing off for FPR10 pending a better chrome detection routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment