bug: cve exploiting malicious connection header #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometherion
force-pushed
the
issues/188
branch
4 times, most recently
from
7df5f5f
to
5af031a
Compare
enj
reviewed
Feb 18, 2022
prometherion
force-pushed
the
issues/188
branch
from
5af031a
to
cfce8be
Compare
|
@prometherion it would be great if a GHSA could be created once this fix is released. |
prometherion
force-pushed
the
issues/188
branch
2 times, most recently
from
553af54
to
6b0536d
Compare
enj
reviewed
Feb 18, 2022
prometherion
force-pushed
the
issues/188
branch
from
6b0536d
to
440944a
Compare
enj
reviewed
Feb 22, 2022
| func (n *kubeFilter) removingHopByHopHeaders(request *http.Request) { | ||
| connectionHeaderName, upgradeHeaderName, requestUpgradeType := "connection", "upgrade", "" | ||
|
|
||
| if httpguts.HeaderValuesContainsToken(request.Header[connectionHeaderName], upgradeHeaderName) { |
There was a problem hiding this comment.
request.Header[connectionHeaderName] is incorrect due to casing of connectionHeaderName.
This was referenced Feb 22, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188.
We strongly suggest upgrading ASAP
capsule-proxyto mitigate this CVE that doesn't have direct mitigation.