Skip to content
Commits on Nov 20, 2014
  1. @rafaelfranca

    Merge pull request #17683 from tgxworld/improvements_to_active_job_guide

    rafaelfranca committed
    [CI SKIP] Improvements to Active Job guide.
  2. @sgrif

    Merge pull request #17669 from SamSaffron/optimise_memory

    sgrif committed
    PERF: avoid string allocations
  3. @tgxworld
  4. @senny

    synchronize code and docs for `timestamps` and `add_timestamps`.

    senny committed
    This makes the following changes:
      * warn if `:null` is not passed to `add_timestamps`
      * `timestamps` method docs link to `add_timestamps` docs
      * explain where additional options go
      * adjust examples to include `null: false` (to prevent deprecation warnings)
Commits on Nov 19, 2014
  1. @SamSaffron
  2. @amatsuda

    Some valid block calls in templates caused syntax errors

    amatsuda committed
    Now ActionView accepts <%= foo(){ %> and <%= foo()do %> :golf:
  3. @rafaelfranca

    Merge pull request #17575 from shikshachauhan/make-habtm-consistent

    rafaelfranca committed
    Allow class_name option in habtm to be consistent with other association...
  4. @rafaelfranca
  5. @sgrif

    Reintroduce cache with tests

    sgrif committed
  6. @sgrif

    Add tests for `TypeMap#fetch` and push up to `TypeMap`

    sgrif committed
    It doesn't make sense for the subclass to implement this method, and not
    have it on the parent. We can also DRY up the implementation of
    `#lookup` to be defined in terms of fetch, which will give us a single
    point of entry
  7. @rafaelfranca

    Merge pull request #17677 from StevenNunez/patch-1

    rafaelfranca committed
    Remove bullet point to unwritten/unreferenced section
  8. @StevenNunez
  9. @sgrif
  10. @sgrif
  11. @sgrif
  12. @rafaelfranca

    Merge pull request #17662 from dtaniwaki/support-symbol-foreign-key-c…

    rafaelfranca committed
    …olumn-to-delete
    
    Support symbol foreign key to delete
  13. @rafaelfranca

    Merge pull request #17672 from radar/date-select-space

    rafaelfranca committed
    Add space in :start_year description for date_select
  14. Add space in :start_year description for date_select

    Ryan Bigg committed
  15. @dtaniwaki
Commits on Nov 18, 2014
  1. @amatsuda

    Duplicated Hash key :prompt

    amatsuda committed
  2. @sgrif

    Improve the performance of reading attributes

    sgrif committed
    We added a comparison to "id", and call to `self.class.primary_key` a
    *lot*. We also have performance hits from `&block` all over the place.
    We skip the check in a new method, in order to avoid breaking the
    behavior of `read_attribute`
  3. @tenderlove
  4. @sgrif

    Speed up integer casting from DB

    sgrif committed
    We don't have the check the range when the value is coming from the DB,
    so override type_cast_from_database to short-circuit the extra work.
    The difference is huge but the absolute gain is quite small. That being
    said this is a hotspot and it showed up on the radar when benchmarking
    discourse.
  5. @rafaelfranca

    Make sure assert_select can assert body tag

    rafaelfranca committed
    This reverts commit f93df52, reversing
    changes made to a455e3f.
    
    Conflicts:
    	actionpack/lib/action_controller/test_case.rb
    	actionview/lib/action_view/test_case.rb
  6. @sgrif

    Remove needless call to `key?` when building attributes

    sgrif committed
    This appears to be a performance hotspot, see #17655.
  7. @sgrif

    LazyAttributeHash is private

    sgrif committed
  8. @sgrif

    Remove call to `key?` in `LazyAttributeHash#[]`

    sgrif committed
    Performance improvement, as well as improved code clarity
  9. @rafaelfranca

    Merge pull request #17665 from javiervidal/fixing_documentation

    rafaelfranca committed
    Ruby on Rails 3.0 Release Notes: fix broken link
  10. @javiervidal
  11. @fxn

    Merge pull request #17660 from rishijain/update_docs_11

    fxn committed
    fixed minor typos in RELEASE doc [ci skip]
  12. @rishijain
  13. @fxn

    Merge pull request #17658 from SamSaffron/optimise_memory

    fxn committed
    PERF: stop allocating the string "id" over and over
  14. @SamSaffron
  15. @chancancode

    Revert "[PERF] Speed up integer type casting from DB"

    chancancode committed
    This reverts commit 6f7910a and 52c70d4.
    
    Query params are type cased through the same method, so this approach doesn't work.
  16. @chancancode

    :nail_care: Put escape clause first, keeps @sgrif happy :grin:

    chancancode committed
    See comment on 6f7910a
Something went wrong with that request. Please try again.