Permalink
Switch branches/tags
Commits on Nov 20, 2014
  1. Merge pull request #17683 from tgxworld/improvements_to_active_job_guide

    rafaelfranca committed Nov 20, 2014
    [CI SKIP] Improvements to Active Job guide.
  2. Merge pull request #17669 from SamSaffron/optimise_memory

    sgrif committed Nov 20, 2014
    PERF: avoid string allocations
  3. synchronize code and docs for `timestamps` and `add_timestamps`.

    senny committed Nov 20, 2014
    This makes the following changes:
      * warn if `:null` is not passed to `add_timestamps`
      * `timestamps` method docs link to `add_timestamps` docs
      * explain where additional options go
      * adjust examples to include `null: false` (to prevent deprecation warnings)
Commits on Nov 19, 2014
  1. Some valid block calls in templates caused syntax errors

    amatsuda committed Nov 19, 2014
    Now ActionView accepts <%= foo(){ %> and <%= foo()do %> ⛳️
  2. Merge pull request #17575 from shikshachauhan/make-habtm-consistent

    rafaelfranca committed Nov 19, 2014
    Allow class_name option in habtm to be consistent with other association...
  3. Reintroduce cache with tests

    sgrif committed Nov 19, 2014
  4. Add tests for `TypeMap#fetch` and push up to `TypeMap`

    sgrif committed Nov 19, 2014
    It doesn't make sense for the subclass to implement this method, and not
    have it on the parent. We can also DRY up the implementation of
    `#lookup` to be defined in terms of fetch, which will give us a single
    point of entry
  5. Merge pull request #17677 from StevenNunez/patch-1

    rafaelfranca committed Nov 19, 2014
    Remove bullet point to unwritten/unreferenced section
  6. Revert "PERF: optimise type lookup to avoid invoking procs"

    sgrif committed Nov 19, 2014
    This reverts commit da99a2a.
  7. Merge pull request #17662 from dtaniwaki/support-symbol-foreign-key-c…

    rafaelfranca committed Nov 19, 2014
    …olumn-to-delete
    
    Support symbol foreign key to delete
  8. Merge pull request #17672 from radar/date-select-space

    rafaelfranca committed Nov 19, 2014
    Add space in :start_year description for date_select
  9. Add space in :start_year description for date_select

    Ryan Bigg
    Ryan Bigg committed Nov 19, 2014
Commits on Nov 18, 2014
  1. Duplicated Hash key :prompt

    amatsuda committed Nov 18, 2014
  2. Improve the performance of reading attributes

    sgrif committed Nov 18, 2014
    We added a comparison to "id", and call to `self.class.primary_key` a
    *lot*. We also have performance hits from `&block` all over the place.
    We skip the check in a new method, in order to avoid breaking the
    behavior of `read_attribute`
  3. Speed up integer casting from DB

    sgrif committed Nov 18, 2014
    We don't have the check the range when the value is coming from the DB,
    so override type_cast_from_database to short-circuit the extra work.
    The difference is huge but the absolute gain is quite small. That being
    said this is a hotspot and it showed up on the radar when benchmarking
    discourse.
  4. Make sure assert_select can assert body tag

    rafaelfranca committed Nov 18, 2014
    This reverts commit f93df52, reversing
    changes made to a455e3f.
    
    Conflicts:
    	actionpack/lib/action_controller/test_case.rb
    	actionview/lib/action_view/test_case.rb
  5. Remove needless call to `key?` when building attributes

    sgrif committed Nov 18, 2014
    This appears to be a performance hotspot, see #17655.
  6. LazyAttributeHash is private

    sgrif committed Nov 18, 2014
  7. Remove call to `key?` in `LazyAttributeHash#[]`

    sgrif committed Nov 18, 2014
    Performance improvement, as well as improved code clarity
  8. Merge pull request #17665 from javiervidal/fixing_documentation

    rafaelfranca committed Nov 18, 2014
    Ruby on Rails 3.0 Release Notes: fix broken link
  9. Merge pull request #17660 from rishijain/update_docs_11

    fxn committed Nov 18, 2014
    fixed minor typos in RELEASE doc [ci skip]
  10. fixed minor typos in RELEASE doc [ci skip]

    Rishi Jain
    Rishi Jain committed Nov 18, 2014
  11. Merge pull request #17658 from SamSaffron/optimise_memory

    fxn committed Nov 18, 2014
    PERF: stop allocating the string "id" over and over
  12. Revert "[PERF] Speed up integer type casting from DB"

    chancancode committed Nov 18, 2014
    This reverts commit 6f7910a and 52c70d4.
    
    Query params are type cased through the same method, so this approach doesn't work.
  13. 💅 Put escape clause first, keeps @sgrif happy 😁

    chancancode committed Nov 18, 2014
    See comment on 6f7910a