Ability to add heading fragments #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,6 +127,32 @@ function applyDirectives(text) { | |||
| return text; | |||
| } | |||
|
|
|||
| function addHeadingFragments(text) { | |||
| if (configuration.getConfig().features.fragments) { | |||
There was a problem hiding this comment.
For better readibility I always prefer to shortcut ifs, like if (!something) { return }. In this case I will "fix it" after the merge :)
claudioc
added a commit
that referenced
this pull request
Dec 14, 2015
Ability to add heading fragments
|
Sorry, I had to revert this one because I doesn't work very well: when you create an headerFragment the html rendering below gets strange (it has something to do with :before element or the icon...). Try adding two or three H one after the other: it seems like the second one get moved to the right |
|
Will give it a go now, I thought I had tested that one. I was going to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #13.
Not sure if there may be a better way of doing this. The problem is the regex for the headings expects the heading to be on a line by itself.