Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Boundary Conditions Bug Fixes #164

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Owner

mandli commented May 1, 2012

This pull request includes a bug fix and additional functionality to the current boundary condition routines:

  • The is_valid routine checked to see if a custom boundary condition was set and then checked if a user defined was provided. The routine mistakenly checked to see if the lower boundary condition was present in both cases.
  • Time dependent aux array support has been added. This required the setting and getting of aux arrays to and from the auxbc array in the solver at every time step. A slight refactoring of the boundary condition routines was also included.

There may be debate about whether the aux arrays should be set at every time step as that theoretically this could lead to overhead. One way around this would be to let the user set a parameter indicating a time dependent aux array but this is currently not included in the pull request.

mandli added some commits Apr 30, 2012

@mandli mandli Bug fix in is_valid 1f22944
@mandli mandli Add set and get auxbc functions, add where needed
This commit seperate and adds functions for setting and getting aux
arrays from and to auxbc arrays.  These calls have also been added to
the stepping routines in clawpack as without them time dependent aux
arrays are not updated properly.  Sharpclaw was not modified.
1989bfe

@ketch ketch referenced this pull request May 20, 2012

Merged

Bc bugfixes #168

Owner

ketch commented May 20, 2012

I rebased this and merged it as pull request #168.

@ketch ketch closed this May 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment