Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in compare_gauges function #619

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@mandli
Copy link
Member

commented Apr 30, 2019

There were some left over bugs for this utility function that allows for comparison between gauges. This is mostly used for testing.

@coveralls

This comment has been minimized.

Copy link

commented Apr 30, 2019

Coverage Status

Coverage remained the same at ?% when pulling fded9a6 on mandli:fix-compare-gauges into d97a74b on clawpack:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Apr 30, 2019

Coverage Status

Coverage remained the same at ?% when pulling fded9a6 on mandli:fix-compare-gauges into d97a74b on clawpack:master.

@mandli

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2019

@ketch does this look like it works well enough? This is a feature for GeoClaw and AMRClaw that has been broken for a bit.

@ketch

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

I don't really know since I don't think I've ever used this function. Is there a test for it somewhere?

I'm fine merging it, but I can't give a meaningful opinion.

@mandli

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

It is mostly used for plotting gauges against each other so no.

@ketch ketch merged commit 2e9d3a7 into clawpack:master Oct 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
cr2940 added a commit to cr2940/pyclaw_old that referenced this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.