Add resize image when Sugarcube is bundled #84

Merged
merged 4 commits into from Jun 18, 2013

2 participants

@rheoli

The resizing before form.render made the App a bit faster.

Example:

{
  title: "Photo",
  key: :photo,
  type: :image,
  max_image_size: [1500,1500],
},
@clayallsopp
Owner

Hey man, I haven't forgotten about this (marked as unread in my inbox).

I think Formotion should have more control over image size, but I'd like to do it in a way that doesn't require sugarcube (or at least has some non-sugarcube fallback). So that's what the current hold-up is :)

@rheoli

Yes, was thinking the same (non-sugarcube fallback). But this will only go with a copy-paste or am I wrong?

@rheoli

Implemented a image resize and changed the code in image_row and paged_image_row (was hard coded before).

Stephan Toggweiler typo aaccb3f
@clayallsopp
Owner

Brilliant!

@clayallsopp clayallsopp merged commit fd83563 into clayallsopp:master Jun 18, 2013

1 check failed

Details default The Travis CI build could not complete due to an error
@rheoli rheoli deleted the unknown repository branch Jun 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment