Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example App has essential buttons hidden under nav bar #24

Closed
NorthStar opened this issue Aug 6, 2014 · 0 comments · Fixed by #25

Comments

@NorthStar
Copy link
Contributor

commented Aug 6, 2014

In the view controllers in the example app:

UIButton *modal = [UIButton buttonWithType:UIButtonTypeRoundedRect];
  [modal setTitle:@"Modal" forState:UIControlStateNormal];
  [modal addTarget:self action:@selector(tapped:) forControlEvents:UIControlEventTouchUpInside];
  [modal sizeToFit];

This makes the frame right under nav bar, and therefore not seen or usable.

NorthStar added a commit to NorthStar/routable-ios that referenced this issue Aug 12, 2014
Set frames: a bit verbose but gets the idea across.
Now the buttons are visible on the bottom of view.
sweetverbs added a commit to sweetverbs/routable-ios that referenced this issue Apr 22, 2015
* addTestsForExtraParams:
  Update to XCTest, add tests for extraParams, fix bug where extraParams were not updated for cached url
  Fixed spacing
  Adds extraParams to openUrl to allow more robust data passing through routing when a controller decides to open an url
  Fixed a type
  Mainly an accent change to use Objective-C style. fixes clayallsopp#26 Objective-C specific syntax fixes:   Verbose naming of methods, adhering to naming conventions   Passive return for nil values   No need to synthesize   Eliminate nil checks through ‘==‘   Eliminate more ‘new’ as allocation and initialization should be separated.   Use custom initialization for dictionaries and arrays for safer type   Separation of allocation and initialization: no more allocating memory when we don’t have to. Completely backward compatible Other caveats that came with idiomatic Objective-C   Safer setObject:forKey: by having early returns if there is no explicit format (to prevent crash)   Simplified logic in conditions   Simplified(?) loops through routes using faster enumeration with blocks   Add explicit factory class methods for constructions   Add default routerOptions Want to do (but didn't/haven't) to adhere to usual Objective-C style   Want to get rid of custom new (newRouter)   Want to have better error handling; no more exception throwing so we get verbose debugging info   Want to simplify controllerForRouterParams and routerParamsForUrl more   Want to get rid of register_name by defining selector macros   Want to replace property shouldOpenAsRootViewController in routerOptions into root’ with getter ‘isRoot’ to parallel modal   Not sure: routerOptions: want to not have wrappers around setters but users might want to keep DSL-style chaining.   Not sure: should I fix spacing more?   Not sure: should callback in options be overridden, ever? Functionality \todo: have both call back and ‘open’ in options. --
  [clayallsopp#24] Example App has essential buttons hidden under nav bar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.