fixed load gem completion bug when gem dir != gem name #7

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@janlelis

For example ripl/plugin ;)
Maybe it's better to look at every require_dir or just say 'lib' instead of spec.require_paths.last

@cldwalker

This comment has been minimized.

Show comment Hide comment
@cldwalker

cldwalker Nov 20, 2010

Owner

This is a valid concern but your solution only solves this for rubygems users. Being mostly a rip user, I'd like to solve this for all gems independent of the gem manager (hence the $: technique).

Owner

cldwalker commented Nov 20, 2010

This is a valid concern but your solution only solves this for rubygems users. Being mostly a rip user, I'd like to solve this for all gems independent of the gem manager (hence the $: technique).

@cldwalker

This comment has been minimized.

Show comment Hide comment
@cldwalker

cldwalker Dec 22, 2010

Owner

Resolved with 1564ac6 . For fresh, just move bond/completions/ripl-fresh.rb to ripl/completions/fresh.rb. No need for the lib/ripl-fresh hack anymore.

Owner

cldwalker commented Dec 22, 2010

Resolved with 1564ac6 . For fresh, just move bond/completions/ripl-fresh.rb to ripl/completions/fresh.rb. No need for the lib/ripl-fresh hack anymore.

@janlelis

This comment has been minimized.

Show comment Hide comment
@janlelis

janlelis Dec 22, 2010

Thanks :)

Thanks :)

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment