Failing tests #80

Closed
eric-hu opened this Issue May 24, 2013 · 11 comments

Comments

Projects
None yet
3 participants

eric-hu commented May 24, 2013

I want try taking a crack at #57, but I'm getting some failing tests. I've created a gist of them here. If this format is hard to read, I can make another gist without the line wrapping.

Am I missing a step or are these expected to be failing right now?

Owner

cldwalker commented May 24, 2013

Thanks for reporting your issue! This is one of my 9 active issues. Use that link to check how soon your issue will be answered. Cheers.

Hi @eric-hu! You're not missing anything, it's a problem in the test suite.

I'm facing the same problem in byebug and haven't found a workaround I like yet. The output on those tests that are failing is dependent on the width set in the debugger: a new line is introduced if the current width is too big for the current output. Your current path (part of the output) is bigger than the one in Travis, so the tests pass there but not in your environment.

You can use something like this as a quick-and-dirty fix to get the tests passing and start working in your issue.

Hope it helps.

Owner

cldwalker commented May 24, 2013

@eric-hu Any pull request to fix these issues, including the quick-and-dirty devid linked to is welcome. I've noticed some intermittent failures (seems due to screen size) but hadn't looked into them.

@eric-hu, the changes in #82 should get you a green test suite to start working on #57, which by the way is very welcome in byebug too... :) Salute.

cldwalker pushed a commit that referenced this issue May 24, 2013

Fixes test failures reported in #80.
You might want to merge this. It should work everywhere unless the user running
the tests has an insanely large cwd. I think it's better than the hack I linked
in issue #80.

cldwalker added a commit that referenced this issue May 24, 2013

Owner

cldwalker commented May 24, 2013

Closing as deivid fixed with #82

@cldwalker cldwalker closed this May 24, 2013

eric-hu commented May 25, 2013

Hmm, I'm getting more failing tests now. They all seem to revolve around "undefined >= for false:FalseClass"

Full gist here

@eric-hu, it seems to me that your suite is now failing because your environment breaks current's debugger minitest dependency

s.add_development_dependency 'minitest', '~> 2.12.1'

eric-hu commented May 25, 2013

@deivid-rodriguez That line is in the gemspec, is that not supposed to be?

Yes, that's why. I see your gist output containing the string minitest-4.7.4, so that makes me think you're not using the right version of minitest...

eric-hu commented May 26, 2013

Ha, good catch. The solution was bundle exec rake. I thought I created
a gemset for this.

Thanks for the patch David!

On Sat, May 25, 2013 at 11:35 PM, David Rodríguez
notifications@github.comwrote:

Yes, that's why. I see in your gist output containing minitest-4.7.4 so
that makes me think you're not using the right version of minitest...


Reply to this email directly or view it on GitHubhttps://github.com/cldwalker/debugger/issues/80#issuecomment-18458788
.

You are welcome! Salute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment