Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

Conversation

@jcvenegas
Copy link
Contributor

Update release version according to new Clear Containers release.

Fixes: #113

Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com

@coveralls
Copy link

coveralls commented Aug 31, 2017

Coverage Status

Coverage remained the same at 74.257% when pulling ab0b804 on jcvenegas:release-beta2 into d7a4dd8 on clearcontainers:master.

@clearcontainersbot
Copy link

Popular Images qa-passed 👍

@chavafg
Copy link
Contributor

chavafg commented Aug 31, 2017

the unit tests work well with Go 1.9, maybe travis is using a newer version of Go for the Go:tip
Is there anyway we can disable that version for our checks?

@sboeuf
Copy link
Contributor

sboeuf commented Aug 31, 2017

@chavafg disabling this version check is easy, you just need to remove this line https://github.com/clearcontainers/proxy/blob/master/.travis.yml#L6
The question is more about, do we want to remove this version check ? @grahamwhaley @sameo @egernst @jodh-intel @mcastelino any thought on that ?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 74.587% when pulling 4fcf012 on jcvenegas:release-beta2 into d7a4dd8 on clearcontainers:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 74.587% when pulling 4fcf012 on jcvenegas:release-beta2 into d7a4dd8 on clearcontainers:master.

@sboeuf
Copy link
Contributor

sboeuf commented Sep 1, 2017

@jcvenegas Nice that you found how to fix the go tip issue, but please submit a separate PR for that. We're gonna merge it first and then we'll be able to merge the beta2 release PR.

@jcvenegas jcvenegas force-pushed the release-beta2 branch 6 times, most recently from 9710609 to a039d01 Compare September 1, 2017 05:46
@coveralls
Copy link

coveralls commented Sep 1, 2017

Coverage Status

Coverage increased (+0.3%) to 74.587% when pulling a039d01 on jcvenegas:release-beta2 into d7a4dd8 on clearcontainers:master.

@clearcontainersbot
Copy link

Popular Images qa-passed 👍

@jcvenegas
Copy link
Contributor Author

@sboeuf created PR #116 after is merged please rerun travis in this PR.

@clearcontainersbot
Copy link

Popular Images qa-passed 👍

@sboeuf
Copy link
Contributor

sboeuf commented Sep 1, 2017

I can't cause I don't have the super power on this repo.We need @amshinde @sameo @mcastelino or @grahamwhaley to be able to merge this one.
After this will be merged (probably in a few hours), you'll be able to rebase this PR and the CI should be happy (hopefully).

@jodh-intel
Copy link

jodh-intel commented Sep 1, 2017

It might be worth blocking this on #112 since the VERSION string isn't required (atleast assuming you have a git checkout).

Update release version according to new Clear Containers release.

Fixes: clearcontainers#113

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Copy link
Contributor

@amshinde amshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Sep 1, 2017

Coverage Status

Coverage increased (+0.3%) to 74.587% when pulling 368f555 on jcvenegas:release-beta2 into f876b41 on clearcontainers:master.

@clearcontainersbot
Copy link

Popular Images qa-passed 👍

@jcvenegas jcvenegas merged commit c0805cc into clearcontainers:master Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants