This repository was archived by the owner on May 6, 2020. It is now read-only.
ci: Display unified diff with what gofmt wants us to change #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run gofmt with the simplify (-s) option. Some of the rewrite rules are hidden behind that flag because they break previous go versions. Editors don't run gofmt with -s by default for that reason and so it's not unlikely the static checks scripts find something to change. We can do better than displaying the list of "offending" files, we can make gofmt display a unified diff with the suggested simplification. It's just a matter of using the -d flag. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
Nice! lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run gofmt with the simplify (-s) option. Some of the rewrite rules
are hidden behind that flag because they break previous go versions.
Editors don't run gofmt with -s by default for that reason and so it's
not unlikely the static checks scripts find something to change.
We can do better than displaying the list of "offending" files, we can
make gofmt display a unified diff with the suggested simplification.
It's just a matter of using the -d flag.
Signed-off-by: Damien Lespiau damien.lespiau@intel.com