This repository was archived by the owner on May 6, 2020. It is now read-only.
vm: Allow newcontainer and execcmd without an I/O token #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we don't need to communicate with the process inside the VM and don't care about its stdout/err for instance. This is the case for the pause container when creating a pod with virtcontainers. Fixes: clearcontainers#32 Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Contributor
|
lgtm |
jodh-intel
reviewed
Apr 13, 2017
|
|
||
| // We don't need a token to start a process inside the VM, but we | ||
| // don't get a session in that case. | ||
| if nTokens == 0 { |
There was a problem hiding this comment.
Is it worth adding a log message here for this "special case"?
Contributor
Author
|
One nit, but otherwise... lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we don't need to communicate with the process inside the
VM and don't care about its stdout/err for instance.
This is the case for the pause container when creating a pod with
virtcontainers.
Fixes: #32
Signed-off-by: Damien Lespiau damien.lespiau@intel.com