This repository was archived by the owner on May 6, 2020. It is now read-only.
vm: Check SendCtlMessage() return to avoid a segmentation fault #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm
|
Contributor
Author
|
@dlespiau Am I supposed to fix those issues ??? I don't think it is related to my PR. Have you already got such issues with gometalinter (megacheck) ? |
Contributor
|
gometalinter has added a checker and we fail on those new checks. |
Contributor
Author
|
@dlespiau Ok thanks for the confirmation. What do you want to do about that ? Removing this checker ? |
sboeuf
force-pushed
the
sboeuf/fix_segfault
branch
from
036fc97 to
dae0de3
Compare
In case the call to SendCtlMessage() was returning an error, the response object was nil, but it was used anyway. This patch makes sure we are not using the response handler in case we got an error. Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
force-pushed
the
sboeuf/fix_segfault
branch
from
dae0de3 to
e24e09b
Compare
Contributor
Author
|
@dlespiau I have disabled megacheck. It's all green. Let me know if you think we should fix megacheck issues instead, but personally I think this PR should not be affected by this issue. We can still re-enable + fix megacheck in a follow up PR. |
Contributor
|
yes, we should fix the few issues (dead code) found by megacheck, that can be a different PR though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the call to SendCtlMessage() was returning an error, the
response object was nil, but it was used anyway.
This patch makes sure we are not using the response handler in
case we got an error.