This repository was archived by the owner on May 6, 2020. It is now read-only.
Add a version flag #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2017 19:59
We can now ask the proxy for its version. The tricky case is when the compilation is done from an archive. We have to then use something else than git describe. We use something similar to what the Linux kernel does, having the version in the Makefile. Fixes: clearcontainers#69 Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
We can now created distribution tarballs with: $ make dist Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
Changes Unknown when pulling 57d1c3e on dlespiau:20170628-version into ** on clearcontainers:master**. |
|
lgtm |
|
@amshinde - could you take a look at this please? |
Contributor
|
lgtm
|
Contributor
|
Hi, seems like the merge of this commit, broke the proxy. Latest tests on semaphore are failing. Opened #90. |
jodh-intel
pushed a commit
to jodh-intel/proxy
that referenced
this pull request
Jul 3, 2017
PR clearcontainers#87 inadvertently broke the build setting the default socket path variable. This appears to be due to a bug in "go build" whereby it accepts any number of -ldflags "-X ..." options, but only actually honours the last one. On PR clearcontainers#87 this meant that the Version variable was set, whilst DefaultSocketPath was silently ignored and its value defaulted to "". Fixes clearcontainers#90. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.